linux-kernel - Re: [PATCH net] ax25: Replace kfree() in ax25_dev_free() with ax25_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <69dee6e9-05c6-4d1e-9c69-a9b60125d7ab@moroto.mountain>
Date: Thu, 30 May 2024 08:23:23 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Duoming Zhou <duoming@....edu.cn>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-hams@...r.kernel.org, pabeni@...hat.com, kuba@...nel.org,
	edumazet@...gle.com, jreuter@...na.de, davem@...emloft.net
Subject: Re: [PATCH net] ax25: Replace kfree() in ax25_dev_free() with
 ax25_dev_put()

On Thu, May 30, 2024 at 01:17:33PM +0800, Duoming Zhou wrote:
> The object "ax25_dev" is managed by reference counting. Thus it should
> not be directly released by kfree(), replace with ax25_dev_put().
> 
> Fixes: d01ffb9eee4a ("ax25: add refcount in ax25_dev to avoid UAF bugs")
> Suggested-by: Dan Carpenter <dan.carpenter@...aro.org>
> Signed-off-by: Duoming Zhou <duoming@....edu.cn>

Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@...aro.org>

regards,
dan carpenter