linux-kernel - Re: [PATCH v19 15/20] fsverity: expose verified fsverity built-in signatures to LSMs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D1MQTEW77RY8.36THC7YDK7CZO@kernel.org>
Date: Thu, 30 May 2024 08:51:21 +0300
From: "Jarkko Sakkinen" <jarkko@...nel.org>
To: "Paul Moore" <paul@...l-moore.com>, "Fan Wu"
 <wufan@...ux.microsoft.com>, <corbet@....net>, <zohar@...ux.ibm.com>,
 <jmorris@...ei.org>, <serge@...lyn.com>, <tytso@....edu>,
 <ebiggers@...nel.org>, <axboe@...nel.dk>, <agk@...hat.com>,
 <snitzer@...nel.org>, <mpatocka@...hat.com>, <eparis@...hat.com>
Cc: <linux-doc@...r.kernel.org>, <linux-integrity@...r.kernel.org>,
 <linux-security-module@...r.kernel.org>, <fsverity@...ts.linux.dev>,
 <linux-block@...r.kernel.org>, <dm-devel@...ts.linux.dev>,
 <audit@...r.kernel.org>, <linux-kernel@...r.kernel.org>, "Deven Bowers"
 <deven.desai@...ux.microsoft.com>
Subject: Re: [PATCH v19 15/20] fsverity: expose verified fsverity built-in
 signatures to LSMs

On Thu May 30, 2024 at 4:44 AM EEST, Paul Moore wrote:
> > +	err = security_inode_setintegrity(inode,
> > +					  LSM_INT_FSVERITY_BUILTINSIG_VALID,
> > +					  signature,
> > +					  le32_to_cpu(sig_size));
>
> I like this much better without the explicit inode cast :)

Would be nice btw if that was 'ret' or 'rc' because err is such
a common name for exception handler alike goto-labels... Looks
confusing just because of that :-)

BR, Jarkko