linux-kernel - RE: [Intel-wired-lan] [PATCH iwl-net 1/3] ice: remove af_xdp_zc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CH3PR11MB83134F4EC024CDB544040707EAF32@CH3PR11MB8313.namprd11.prod.outlook.com>
Date: Thu, 30 May 2024 05:53:42 +0000
From: "Rout, ChandanX" <chandanx.rout@...el.com>
To: "Zaremba, Larysa" <larysa.zaremba@...el.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
	"Keller, Jacob E" <jacob.e.keller@...el.com>
CC: "Fijalkowski, Maciej" <maciej.fijalkowski@...el.com>, "Jesper Dangaard
 Brouer" <hawk@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, "Kitszel,
 Przemyslaw" <przemyslaw.kitszel@...el.com>, John Fastabend
	<john.fastabend@...il.com>, Alexei Starovoitov <ast@...nel.org>, "David S.
 Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, Jakub Kicinski
	<kuba@...nel.org>, "bpf@...r.kernel.org" <bpf@...r.kernel.org>, Paolo Abeni
	<pabeni@...hat.com>, Magnus Karlsson <magnus.karlsson@...il.com>, "Bagnucki,
 Igor" <igor.bagnucki@...el.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "Kuruvinakunnel, George"
	<george.kuruvinakunnel@...el.com>, "Pandey, Atul" <atul.pandey@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-net 1/3] ice: remove af_xdp_zc_qps
 bitmap



>-----Original Message-----
>From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
>Zaremba, Larysa
>Sent: Wednesday, May 15, 2024 9:32 PM
>To: intel-wired-lan@...ts.osuosl.org; Keller, Jacob E <jacob.e.keller@...el.com>
>Cc: Fijalkowski, Maciej <maciej.fijalkowski@...el.com>; Jesper Dangaard Brouer
><hawk@...nel.org>; Daniel Borkmann <daniel@...earbox.net>; Zaremba,
>Larysa <larysa.zaremba@...el.com>; Kitszel, Przemyslaw
><przemyslaw.kitszel@...el.com>; John Fastabend
><john.fastabend@...il.com>; Alexei Starovoitov <ast@...nel.org>; David S.
>Miller <davem@...emloft.net>; Eric Dumazet <edumazet@...gle.com>;
>netdev@...r.kernel.org; Jakub Kicinski <kuba@...nel.org>;
>bpf@...r.kernel.org; Paolo Abeni <pabeni@...hat.com>; Magnus Karlsson
><magnus.karlsson@...il.com>; Bagnucki, Igor <igor.bagnucki@...el.com>;
>linux-kernel@...r.kernel.org
>Subject: [Intel-wired-lan] [PATCH iwl-net 1/3] ice: remove af_xdp_zc_qps
>bitmap
>
>Referenced commit has introduced a bitmap to distinguish between ZC and
>copy-mode AF_XDP queues, because xsk_get_pool_from_qid() does not do
>this for us.
>
>The bitmap would be especially useful when restoring previous state after
>rebuild, if only it was not reallocated in the process. This leads to e.g.
>xdpsock dying after changing number of queues.
>
>Instead of preserving the bitmap during the rebuild, remove it completely and
>distinguish between ZC and copy-mode queues based on the presence of a
>device associated with the pool.
>
>Fixes: e102db780e1c ("ice: track AF_XDP ZC enabled queues in bitmap")
>Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
>Signed-off-by: Larysa Zaremba <larysa.zaremba@...el.com>
>---
> drivers/net/ethernet/intel/ice/ice.h     | 32 ++++++++++++++++--------
> drivers/net/ethernet/intel/ice/ice_lib.c |  8 ------
>drivers/net/ethernet/intel/ice/ice_xsk.c | 13 +++++-----
> 3 files changed, 27 insertions(+), 26 deletions(-)
>

Tested-by: Chandan Kumar Rout <chandanx.rout@...el.com> (A Contingent Worker at Intel)