linux-kernel - Re: [PATCH v2 12/14] mfd: pm8008: rework driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zlg0Kn8gI1zKhPct@hovoldconsulting.com>
Date: Thu, 30 May 2024 10:09:14 +0200
From: Johan Hovold <johan@...nel.org>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: Johan Hovold <johan+linaro@...nel.org>, Lee Jones <lee@...nel.org>,
	Mark Brown <broonie@...nel.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Bjorn Andersson <andersson@...nel.org>,
	Konrad Dybcio <konrad.dybcio@...aro.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Das Srinagesh <quic_gurus@...cinc.com>,
	Satya Priya Kakitapalli <quic_skakitap@...cinc.com>,
	Stephen Boyd <swboyd@...omium.org>,
	Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
	linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org
Subject: Re: [PATCH v2 12/14] mfd: pm8008: rework driver

On Wed, May 29, 2024 at 10:53:09PM +0300, Andy Shevchenko wrote:
> On Wed, May 29, 2024 at 7:30 PM Johan Hovold <johan+linaro@...nel.org> wrote:

> > +       ret = devm_regmap_add_irq_chip_fwnode(dev, fwnode, regmap, client->irq,
> >                                 IRQF_SHARED, 0, &pm8008_irq_chip, &irq_data);
> > +       if (ret) {
> > +               dev_err(dev, "failed to add IRQ chip: %d\n", ret);
> > +               return ret;
> >         }
> 
> I believe there is no harm to use
> 
>   return dev_err_probe(...);
> 
> for these. But it seems you don't like that API. Whatever, no-one will
> die, just additional work for the future :-)

Correct. And there's no additional work for the future here either.

Johan