linux-kernel - RE: [PATCH v2 18/20] pinctrl: freescale: mxs: Fix refcount of child

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 30 May 2024 08:44:08 +0000
From: Peng Fan <peng.fan@....com>
To: Markus Elfring <Markus.Elfring@....de>, "soc@...nel.org" <soc@...nel.org>,
	Alexandre Belloni <alexandre.belloni@...tlin.com>, Alexandre Torgue
	<alexandre.torgue@...s.st.com>, Alim Akhtar <alim.akhtar@...sung.com>, Andrew
 Jeffery <andrew@...econstruct.com.au>, Angelo Gioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>, Baolin Wang
	<baolin.wang@...ux.alibaba.com>, Chester Lin <chester62515@...il.com>,
	Chunyan Zhang <zhang.lyra@...il.com>, Claudiu Beznea
	<claudiu.beznea@...on.dev>, Damien Le Moal <dlemoal@...nel.org>, Dan
 Carpenter <dan.carpenter@...aro.org>, Aisheng Dong <aisheng.dong@....com>,
	Dvorkin Dmitry <dvorkin@...bo.com>, Emil Renner Berthing <kernel@...il.dk>,
	Fabio Estevam <festevam@...il.com>, Geert Uytterhoeven
	<geert+renesas@...der.be>, "Ghennadi Procopciuc (OSS)"
	<ghennadi.procopciuc@....nxp.com>, Hal Feng <hal.feng@...rfivetech.com>,
	Heiko Stübner <heiko@...ech.de>, Jacky Bai
	<ping.bai@....com>, Jianlong Huang <jianlong.huang@...rfivetech.com>, Joel
 Stanley <joel@....id.au>, Jonathan Hunter <jonathanh@...dia.com>, Krzysztof
 Kozlowski <krzk@...nel.org>, Linus Walleij <linus.walleij@...aro.org>,
	Ludovic Desroches <ludovic.desroches@...rochip.com>, Matthias Brugger
	<matthias.bgg@...il.com>, Matthias Brugger <mbrugger@...e.com>, Maxime
 Coquelin <mcoquelin.stm32@...il.com>, Nicolas Ferre
	<nicolas.ferre@...rochip.com>, Orson Zhai <orsonzhai@...il.com>, Patrice
 Chotard <patrice.chotard@...s.st.com>, Sascha Hauer <s.hauer@...gutronix.de>,
	Sean Wang <sean.wang@...nel.org>, Shawn Guo <shawnguo@...nel.org>, Shiraz
 Hashim <shiraz.linux.kernel@...il.com>, Stephen Warren
	<swarren@...dotorg.org>, Sylwester Nawrocki <s.nawrocki@...sung.com>, Thierry
 Reding <thierry.reding@...il.com>, Tony Lindgren <tony@...mide.com>, Viresh
 Kumar <vireshk@...nel.org>, Wells Lu <wellslutw@...il.com>
CC: LKML <linux-kernel@...r.kernel.org>, "linux-gpio@...r.kernel.org"
	<linux-gpio@...r.kernel.org>, "linux-tegra@...r.kernel.org"
	<linux-tegra@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-stm32@...md-mailman.stormreply.com"
	<linux-stm32@...md-mailman.stormreply.com>,
	"linux-samsung-soc@...r.kernel.org" <linux-samsung-soc@...r.kernel.org>,
	"linux-renesas-soc@...r.kernel.org" <linux-renesas-soc@...r.kernel.org>,
	"linux-rockchip@...ts.infradead.org" <linux-rockchip@...ts.infradead.org>,
	"linux-riscv@...ts.infradead.org" <linux-riscv@...ts.infradead.org>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>, "linux-aspeed@...ts.ozlabs.org"
	<linux-aspeed@...ts.ozlabs.org>, "openbmc@...ts.ozlabs.org"
	<openbmc@...ts.ozlabs.org>, "kernel@...gutronix.de" <kernel@...gutronix.de>,
	"Peng Fan (OSS)" <peng.fan@....nxp.com>
Subject: RE: [PATCH v2 18/20] pinctrl: freescale: mxs: Fix refcount of child

> Subject: Re: [PATCH v2 18/20] pinctrl: freescale: mxs: Fix refcount of child
> 
> How do you think about to use the summary phrase “Fix reference counting
> for children in mxs_pinctrl_probe_dt()”?

Thanks for reviewing. I have no plan to rework this series for non-accepted
patches. If you have interest and time, feel free to take it.

Thanks,
Peng.
> 
> 
> …
> > of_get_next_child() will increase refcount …
> 
>                                     the reference counter?
> 
> 
> > Per current implementation, 'child' will be override by
> 
>                                               overridden?
> 
> 
> > for_each_child_of_node(np, child), so use of_get_child_count to avoid
> > refcount leakage.
> 
> Another wording suggestion:
>   for_each_child_of_node(np, child). Thus use an of_get_child_count() call
>   to avoid reference counting leakage.
> 
> 
> Regards,
> Markus