linux-kernel - Re: [PATCH net] net: phy: Micrel KSZ8061: fix errata solution not taking effect problem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b52073452a085524b436762aeb3aff8feb8005d1.camel@redhat.com>
Date: Thu, 30 May 2024 11:21:59 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Tristram.Ha@...rochip.com, Andrew Lunn <andrew@...n.ch>, Heiner Kallweit
	 <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>,  Jakub Kicinski <kuba@...nel.org>,
 UNGLinuxDriver@...rochip.com, netdev@...r.kernel.org, 
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: phy: Micrel KSZ8061: fix errata solution not
 taking effect problem

On Tue, 2024-05-28 at 14:37 -0700, Tristram.Ha@...rochip.com wrote:
> From: Tristram Ha <tristram.ha@...rochip.com>
> 
> KSZ8061 needs to write to a MMD register at driver initialization to fix
> an errata.  This worked in 4.14 kernel but not in newer kernels.  The
> issue is the main phylib code no longer resets PHY at the very beginning.
> Calling phy resuming code later will reset the chip if it is already
> powered down at the beginning.  This wipes out the MMD register write.
> Solution is to implement a phy resume function for KSZ8061 to take care
> of this problem.
> 
> Fixes: 232ba3a51cc2 ("net: phy: Micrel KSZ8061: link failure after cable connect")

As the blamed commit belongs to 5.0 and the changelog hints anything
after 4.14 is broken, it looks like there is an inconsistency. Please
fix the changelog or the tag.

Thanks,

Paolo