linux-kernel - RE: [PATCH net-next v13 12/14] net: ptp: Move ptp_clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 30 May 2024 11:23:10 +0000
From: Sai Krishna Gajula <saikrishnag@...vell.com>
To: Kory Maincent <kory.maincent@...tlin.com>,
        Florian Fainelli
	<florian.fainelli@...adcom.com>,
        Broadcom internal kernel review list
	<bcm-kernel-feedback-list@...adcom.com>,
        Andrew Lunn <andrew@...n.ch>, Heiner
 Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        "David
 S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub
 Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Richard Cochran
	<richardcochran@...il.com>,
        Radu Pirea <radu-nicolae.pirea@....nxp.com>,
        Jay
 Vosburgh <j.vosburgh@...il.com>,
        Andy Gospodarek <andy@...yhouse.net>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Claudiu Beznea
	<claudiu.beznea@...on.dev>,
        Willem de Bruijn
	<willemdebruijn.kernel@...il.com>,
        Jonathan Corbet <corbet@....net>,
        Horatiu
 Vultur <horatiu.vultur@...rochip.com>,
        "UNGLinuxDriver@...rochip.com"
	<UNGLinuxDriver@...rochip.com>,
        Simon Horman <horms@...nel.org>,
        Vladimir
 Oltean <vladimir.oltean@....com>
CC: Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        "linux-doc@...r.kernel.org"
	<linux-doc@...r.kernel.org>,
        Maxime Chevallier
	<maxime.chevallier@...tlin.com>,
        Rahul Rameshbabu <rrameshbabu@...dia.com>
Subject: RE:  [PATCH net-next v13 12/14] net: ptp: Move ptp_clock_index() to
 builtin symbol


> -----Original Message-----
> From: Kory Maincent <kory.maincent@...tlin.com>
> Sent: Wednesday, May 29, 2024 3:10 PM
> To: Florian Fainelli <florian.fainelli@...adcom.com>; Broadcom internal kernel
> review list <bcm-kernel-feedback-list@...adcom.com>; Andrew Lunn
> <andrew@...n.ch>; Heiner Kallweit <hkallweit1@...il.com>; Russell King
> <linux@...linux.org.uk>; David S. Miller <davem@...emloft.net>; Eric
> Dumazet <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo
> Abeni <pabeni@...hat.com>; Richard Cochran <richardcochran@...il.com>;
> Radu Pirea <radu-nicolae.pirea@....nxp.com>; Jay Vosburgh
> <j.vosburgh@...il.com>; Andy Gospodarek <andy@...yhouse.net>; Nicolas
> Ferre <nicolas.ferre@...rochip.com>; Claudiu Beznea
> <claudiu.beznea@...on.dev>; Willem de Bruijn
> <willemdebruijn.kernel@...il.com>; Jonathan Corbet <corbet@....net>;
> Horatiu Vultur <horatiu.vultur@...rochip.com>;
> UNGLinuxDriver@...rochip.com; Simon Horman <horms@...nel.org>;
> Vladimir Oltean <vladimir.oltean@....com>
> Cc: Thomas Petazzoni <thomas.petazzoni@...tlin.com>;
> netdev@...r.kernel.org; linux-kernel@...r.kernel.org; linux-
> doc@...r.kernel.org; Maxime Chevallier <maxime.chevallier@...tlin.com>;
> Rahul Rameshbabu <rrameshbabu@...dia.com>; Kory Maincent
> <kory.maincent@...tlin.com>
> Subject: [PATCH net-next v13 12/14] net: ptp: Move
> ptp_clock_index() to builtin symbol
> 
> Move ptp_clock_index() to builtin symbols to prepare for supporting get and
> set hardware timestamps from ethtool, which is builtin.
> 
> Signed-off-by: Kory Maincent <kory.maincent@...tlin.com>
> ---
> 
> Change in v13:
> - New patch
> ---
>  drivers/ptp/ptp_clock.c          | 6 ------
>  drivers/ptp/ptp_clock_consumer.c | 6 ++++++
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/ptp/ptp_clock.c b/drivers/ptp/ptp_clock.c index
> 593b5c906314..fc4b266abe1d 100644
> --- a/drivers/ptp/ptp_clock.c
> +++ b/drivers/ptp/ptp_clock.c
> @@ -460,12 +460,6 @@ void ptp_clock_event(struct ptp_clock *ptp, struct
> ptp_clock_event *event)  }  EXPORT_SYMBOL(ptp_clock_event);
> 
> -int ptp_clock_index(struct ptp_clock *ptp) -{
> -	return ptp->index;
> -}
> -EXPORT_SYMBOL(ptp_clock_index);
> -
>  int ptp_find_pin(struct ptp_clock *ptp,
>  		 enum ptp_pin_function func, unsigned int chan)  { diff --git
> a/drivers/ptp/ptp_clock_consumer.c b/drivers/ptp/ptp_clock_consumer.c
> index 759dd6f63405..2322fa65075e 100644
> --- a/drivers/ptp/ptp_clock_consumer.c
> +++ b/drivers/ptp/ptp_clock_consumer.c
> @@ -97,3 +97,9 @@ void ptp_clock_put(struct device *dev, struct ptp_clock
> *ptp)
>  	put_device(&ptp->dev);
>  	module_put(ptp->info->owner);
>  }
> +
> +int ptp_clock_index(struct ptp_clock *ptp) {
> +	return ptp->index;
> +}
> +EXPORT_SYMBOL(ptp_clock_index);
> 
Please check the "build_clang - FAILED", "build_32bit - FAILED" build errors.
> --
> 2.34.1
>