linux-kernel - Re: [PATCH 1/9] pinctrl: renesas: rzg2l: Fix variable names in OEN functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdUkmMGU=S_6B=h+TLH3E=M0BhVCJn03axGsq_FPOKiDJQ@mail.gmail.com>
Date: Thu, 30 May 2024 14:47:55 +0200
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Paul Barker <paul.barker.ct@...renesas.com>
Cc: Magnus Damm <magnus.damm@...il.com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Linus Walleij <linus.walleij@...aro.org>, linux-renesas-soc@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-gpio@...r.kernel.org, 
	linux-kernel@...r.kernel.org, 
	"Lad, Prabhakar" <prabhakar.mahadev-lad.rj@...renesas.com>, 
	Claudiu Beznea <claudiu.beznea.uj@...renesas.com>
Subject: Re: [PATCH 1/9] pinctrl: renesas: rzg2l: Fix variable names in OEN functions

Hi Paul,

On Fri, May 24, 2024 at 11:46 AM Paul Barker
<paul.barker.ct@...renesas.com> wrote:
> The variable naming in the various OEN functions has been confusing. We
> were passing the _pin variable from rzg2l_pinctrl_pinconf_get() and
> rzg2l_pinctrl_pinconf_set() as the offset argument to rzg2l_read_oen()
> and rzg2l_write_oen(), when this is not a register offset.
>
> What we actually need here is the port index, so that we can compare
> this to oen_max_port.
>
> We can also clean up rzg2l_pin_to_oen_bit(), removing an unnecessary
> branch and clarifying the variable naming.
>
> Signed-off-by: Paul Barker <paul.barker.ct@...renesas.com>

I think this makes sense.
It will impact Prabhakar's RZ/V2H series, which demultiplexes
these for RZ/V2H vs. RZ/G2L (G3S).

Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68korg

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds