linux-kernel - device_def_domain_type documentation header does not match implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <14311965.TaHA55BQu8@bagend>
Date: Thu, 30 May 2024 15:57:38 +0200
From: Diederik de Haas <didi.debian@...ow.org>
To: David Woodhouse <dwmw2@...radead.org>,
 Lu Baolu <baolu.lu@...ux.intel.com>, Joerg Roedel <joro@...tes.org>,
 Will Deacon <will@...nel.org>
Cc: Robin Murphy <robin.murphy@....com>, iommu@...ts.linux.dev,
 linux-kernel@...r.kernel.org, Diederik de Haas <didi.debian@...ow.org>
Subject:
 device_def_domain_type documentation header does not match implementation

Hi,

While looking into ``drivers/iommu/intel/iommu.c::device_def_domain_type`` 
function I noticed a discrepancy between the documentation header and the 
implementation.

``@...rtup: true if this is during early boot``
0e31a7266508 ("iommu/vt-d: Remove startup parameter from 
device_def_domain_type()")
removed the ``startup`` function parameter

returns ``IOMMU_DOMAIN_DMA: device requires a dynamic mapping domain``
28b41e2c6aeb ("iommu: Move def_domain type check for untrusted device into 
core") 
moved the possible return of ``IOMMU_DOMAIN_DMA`` to ``drivers/iommu/iommu.c``

But neither updated the documentation header.

Cheers,
  Diederik
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)