[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240530142510.734-1-avri.altman@wdc.com>
Date: Thu, 30 May 2024 17:25:06 +0300
From: Avri Altman <avri.altman@....com>
To: "Martin K . Petersen" <martin.petersen@...cle.com>
Cc: Bart Van Assche <bvanassche@....org>,
Bean Huo <beanhuo@...ron.com>,
Peter Wang <peter.wang@...iatek.com>,
linux-scsi@...r.kernel.org,
linux-kernel@...r.kernel.org,
Avri Altman <avri.altman@....com>
Subject: [PATCH v7 0/3] scsi: ufs: Allow RTT negotiation
The rtt-upiu packets precede any data-out upiu packets, thus
synchronizing the data input to the device: this mostly applies to write
operations, but there are other operations that requires rtt as well.
There are several rules binding this rtt - data-out dialog, specifically
There can be at most outstanding bMaxNumOfRTT such packets. This might
have an effect on write performance (sequential write in particular), as
each data-out upiu must wait for its rtt sibling.
UFSHCI expects bMaxNumOfRTT to be min(bDeviceRTTCap, NORTT). However,
as of today, there does not appear to be no-one who sets it: not the
host controller nor the driver. It wasn't an issue up to now:
bMaxNumOfRTT is set to 2 after manufacturing, and wasn't limiting the
write performance.
UFS4.0, and specifically gear 5 changes this, and requires the device to
be more attentive. This doesn't come free - the device has to allocate
more resources to that end, but the sequential write performance
improvement is significant. Early measurements shows 25% gain when
moving from rtt 2 to 9. Therefore, set bMaxNumOfRTT to be
min(bDeviceRTTCap, NORTT) as UFSHCI expects.
v6 -> v7:
Some more comments to patches 2 & 3 (Bart)
v5 -> v6:
Use blk_mq_<un>freeze_queue to drain the queues (Bart)
Replace the rtt_set() vop by a max_num_rtt constant (Cristoph/Bart)
v4 -> v5:
Quiesce the queues before writing bMaxNumOfRTT (Bart)
Make bDeviceRTTCap available in ufshcd_device_params_init() (Bart)
v3 -> v4:
Allow bMaxNumOfRTT to be configured via sysfs (Bart)
v2 -> v3:
Allow platform vendors to take precedence having their own rtt
negotiation mechanism (Peter)
v1 -> v2:
bMaxNumOfRTT is a Persistent attribute - do not override if it was
written (Bean)
Avri Altman (3):
scsi: ufs: Allow RTT negotiation
scsi: ufs: Maximum RTT supported by the host driver
scsi: ufs: sysfs: Make max_number_of_rtt read-write
Documentation/ABI/testing/sysfs-driver-ufs | 14 +++--
drivers/ufs/core/ufs-sysfs.c | 73 +++++++++++++++++++++-
drivers/ufs/core/ufshcd.c | 41 ++++++++++++
drivers/ufs/host/ufs-mediatek.c | 1 +
drivers/ufs/host/ufs-mediatek.h | 3 +
include/ufs/ufs.h | 2 +
include/ufs/ufshcd.h | 4 ++
include/ufs/ufshci.h | 1 +
8 files changed, 132 insertions(+), 7 deletions(-)
--
2.34.1
Powered by blists - more mailing lists