[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240530143254.GE2770@thinkpad>
Date: Thu, 30 May 2024 20:02:54 +0530
From: Manivannan Sadhasivam <mani@...nel.org>
To: Shashank Babu Chinta Venkata <quic_schintav@...cinc.com>
Cc: jingoohan1@...il.com, gustavo.pimentel@...opsys.com,
manivannan.sadhasivam@...aro.org, andersson@...nel.org,
agross@...nel.org, konrad.dybcio@...aro.org,
quic_msarkar@...cinc.com, quic_kraravin@...cinc.com,
Lorenzo Pieralisi <lpieralisi@...nel.org>,
Krzysztof Wilczyński <kw@...ux.com>,
Rob Herring <robh@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
Serge Semin <fancer.lancer@...il.com>,
Conor Dooley <conor.dooley@...rochip.com>,
linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v4 0/3] pci: qcom: Add 16GT/s equalization and margining
settings
On Wed, May 01, 2024 at 09:35:31AM -0700, Shashank Babu Chinta Venkata wrote:
> Add 16GT/s specific equalization and rx lane margining settings. These
> settings are inline with respective PHY settings for 16GT/s
> operation.
>
> In addition, current QCOM EP and RC drivers do not share common
> codebase which would result in code duplication. Hence, adding
> common files for code reusability among RC and EP drivers.
>
For the next revision, please rebase on top of [1].
- Mani
[1] https://lore.kernel.org/linux-pci/20240518-opp_support-v13-2-78c73edf50de@quicinc.com/
> v3 -> v4:
> - Addressed review comments from Mani and Konrad.
> - Preceded subject line with pci: qcom: tags
>
> v2 -> v3:
> - Replaced FIELD_GET/FIELD_PREP macros for bit operations.
> - Renamed cmn to common.
> - Avoided unnecessary argument validations.
> - Addressed review comments from Konrad and Mani.
>
> v1 -> v2:
> - Capitilized commit message to be inline with history
> - Dropped stubs from header file.
> - Moved Designware specific register offsets and masks to
> pcie-designware.h header file.
> - Applied settings based on bus data rate rather than link generation.
> - Addressed review comments from Bjorn and Frank.
>
> Shashank Babu Chinta Venkata (3):
> PCI: qcom: Refactor common code
> PCI: qcom: Add equalization settings for 16 GT/s
> PCI: qcom: Add RX margining settings for 16 GT/s
>
> drivers/pci/controller/dwc/Kconfig | 5 +
> drivers/pci/controller/dwc/Makefile | 1 +
> drivers/pci/controller/dwc/pcie-designware.h | 30 ++++
> drivers/pci/controller/dwc/pcie-qcom-common.c | 144 ++++++++++++++++++
> drivers/pci/controller/dwc/pcie-qcom-common.h | 14 ++
> drivers/pci/controller/dwc/pcie-qcom-ep.c | 44 ++----
> drivers/pci/controller/dwc/pcie-qcom.c | 74 ++-------
> 7 files changed, 218 insertions(+), 94 deletions(-)
> create mode 100644 drivers/pci/controller/dwc/pcie-qcom-common.c
> create mode 100644 drivers/pci/controller/dwc/pcie-qcom-common.h
>
> --
> 2.43.2
>
--
மணிவண்ணன் சதாசிவம்
Powered by blists - more mailing lists