linux-kernel - Re: [PATCH 1/2] x86/percpu: Fix "multiple identical address spaces specified for type" clang warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240530155758.GA2974773@thelio-3990X>
Date: Thu, 30 May 2024 08:57:58 -0700
From: Nathan Chancellor <nathan@...nel.org>
To: Uros Bizjak <ubizjak@...il.com>
Cc: x86@...nel.org, llvm@...ts.linux.dev, linux-kernel@...r.kernel.org,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...nel.org>, Borislav Petkov <bp@...en8.de>,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Nick Desaulniers <ndesaulniers@...gle.com>,
	Bill Wendling <morbo@...gle.com>,
	Justin Stitt <justinstitt@...gle.com>
Subject: Re: [PATCH 1/2] x86/percpu: Fix "multiple identical address spaces
 specified for type" clang warning

On Sun, May 26, 2024 at 07:55:52PM +0200, Uros Bizjak wrote:
> The clang build with named address spaces enabled currently fails with:
> 
> error: multiple identical address spaces specified for type [-Werror,-Wduplicate-decl-specifier]
> 
> The warning is emitted when accessing const_pcpu_hot structure,
> which is already declared in __seg_gs named address space.
> 
> Use specialized accessor for __raw_cpu_read_const() instead, avoiding
> redeclaring __seg_gs named address space via __raw_cpu_read().
> 
> Signed-off-by: Uros Bizjak <ubizjak@...il.com>

Thanks, this resolves the warning for me when patch 2 is applied.

Acked-by: Nathan Chancellor <nathan@...nel.org>

However, as both of us have noticed [1][2], there is a problem in LLVM's
x86 backend with the address space casting that the kernel does, so
patch 2 should not be merged.

[1]: https://github.com/ClangBuiltLinux/linux/issues/2013
[2]: https://github.com/llvm/llvm-project/issues/93449

> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Ingo Molnar <mingo@...nel.org>
> Cc: Borislav Petkov <bp@...en8.de>
> Cc: Dave Hansen <dave.hansen@...ux.intel.com>
> Cc: "H. Peter Anvin" <hpa@...or.com>
> Cc: Nathan Chancellor <nathan@...nel.org>
> Cc: Nick Desaulniers <ndesaulniers@...gle.com>
> Cc: Bill Wendling <morbo@...gle.com>
> Cc: Justin Stitt <justinstitt@...gle.com>
> ---
>  arch/x86/include/asm/percpu.h | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/x86/include/asm/percpu.h b/arch/x86/include/asm/percpu.h
> index c55a79d5feae..aeea5c8a17de 100644
> --- a/arch/x86/include/asm/percpu.h
> +++ b/arch/x86/include/asm/percpu.h
> @@ -160,7 +160,10 @@ do {									\
>  	*(qual __my_cpu_type(pcp) *)__my_cpu_ptr(&(pcp)) = (val);	\
>  } while (0)
>  
> -#define __raw_cpu_read_const(pcp)	__raw_cpu_read(, , pcp)
> +#define __raw_cpu_read_const(pcp)					\
> +({									\
> +	*(typeof(pcp) *)(__force uintptr_t)(&(pcp));			\
> +})
>  
>  #else /* !CONFIG_USE_X86_SEG_SUPPORT: */
>  
> -- 
> 2.42.0
>