linux-kernel - Re: [PATCH net-next] net: smc91x: Refactor SMC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 29 May 2024 17:17:40 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Thorsten Blum <thorsten.blum@...lux.com>
Cc: Nicolas Pitre <nico@...xnic.net>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, Breno Leitao <leitao@...ian.org>, Uwe Kleine-König <u.kleine-koenig@...gutronix.de>, Andrew Lunn
 <andrew@...n.ch>, John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>,
 Arnd Bergmann <arnd@...db.de>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: smc91x: Refactor SMC_* macros

On Tue, 28 May 2024 12:44:23 +0200 Thorsten Blum wrote:
> Use the macro parameter lp directly instead of relying on ioaddr being
> defined in the surrounding scope.

Have you tested this, or just compile tested (please mention what
testing has been done in the commit message in the future)?

What's the motivation - cleanup or this helps remove some warnings?
(again, please mention in the commit message)

AFAICT this will break smc_probe().
-- 
pw-bot: cr