linux-kernel - Re: [PATCH] tick: shift tick_nohz_switch_to_nohz() from tick_check_oneshot_change() to hrtimer_run

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZlizhBuU3tVWW2Mm@redhat.com>
Date: Thu, 30 May 2024 13:12:36 -0400
From: Oleg Nesterov <oleg@...hat.com>
To: Frederic Weisbecker <frederic@...nel.org>
Cc: Thomas Gleixner <tglx@...utronix.de>,
	Anna-Maria Behnsen <anna-maria@...utronix.de>,
	Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tick: shift tick_nohz_switch_to_nohz() from
 tick_check_oneshot_change() to hrtimer_run_queues()

On 05/30, Frederic Weisbecker wrote:
>
> > +extern int tick_check_oneshot_change(void);
> > +extern void tick_nohz_switch_to_nohz(void);
>
> tick_nohz_switch_to_nohz() is only built with CONFIG_NO_HZ_COMMON
>
> You will have a build issue with CONFIG_HIGH_RES_TIMER && !CONFIG_NO_HZ_COMMON

Hmm. I naively thought that a dummy definition below should be enough...

Thanks! I'll recheck and reply on Saturday.

Oleg.

> >  #else /* !CONFIG_TICK_ONESHOT: */
> >  static inline
> > @@ -124,7 +125,8 @@ static inline void tick_oneshot_notify(void) { }
> >  static inline bool tick_oneshot_possible(void) { return false; }
> >  static inline int tick_oneshot_mode_active(void) { return 0; }
> >  static inline void tick_clock_notify(void) { }
> > -static inline int tick_check_oneshot_change(int allow_nohz) { return 0; }
> > +static inline int tick_check_oneshot_change(void) { return 0; }
> > +static inline void tick_nohz_switch_to_nohz(void) { }
> >  #endif /* !CONFIG_TICK_ONESHOT */
>