linux-kernel - Re: [PATCH 2/3] hwmon: Add support for SPD5118 compliant temperature sensors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <be9a987d-9fca-4ef9-be58-58d7b4d8f26d@roeck-us.net>
Date: Thu, 30 May 2024 10:36:43 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Armin Wolf <W_Armin@....de>, linux-hwmon@...r.kernel.org
Cc: Hristo Venev <hristo@...ev.name>, René Rebe
 <rene@...ctcode.de>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, Radu Sabau <radu.sabau@...log.com>
Subject: Re: [PATCH 2/3] hwmon: Add support for SPD5118 compliant temperature
 sensors

On 5/30/24 10:03, Armin Wolf wrote:
[ ... ]
>> +
>> +
>> +PEC configuration
>> +-----------------
>> +
>> +If the I2C/SMBus controller supports PEC, it can be enabled or disabled using
>> +the 'pec' sysfs attribute attached to the i2c device.
>> +
> 
> Hi,
> 
> the spd5118 only supports PEC when in i3c basic mode, so afaik we cannot use PEC here.
> 

Thanks for noticing. I misread the spec and associated the note with PAR_DIS,
not PEC_EN. I'll drop this and the PEC patch. Good that I kept it separate.

Thanks,
Guenter