linux-kernel - Re: [PATCH] hns3: avoid linking objects into multiple modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 30 May 2024 10:58:57 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Arnd Bergmann <arnd@...nel.org>, Yisen Zhuang <yisen.zhuang@...wei.com>,
	Salil Mehta <salil.mehta@...wei.com>, Jijie Shao <shaojijie@...wei.com>
CC: Arnd Bergmann <arnd@...db.de>, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, "Paolo
 Abeni" <pabeni@...hat.com>, Leon Romanovsky <leon@...nel.org>, "Masahiro
 Yamada" <masahiroy@...nel.org>, Hao Lan <lanhao@...wei.com>, Peiyang Wang
	<wangpeiyang1@...wei.com>, Jie Wang <wangjie125@...wei.com>, Michal Kubiak
	<michal.kubiak@...el.com>, Kalesh AP <kalesh-anakkur.purayil@...adcom.com>,
	Guangbin Huang <huangguangbin2@...wei.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] hns3: avoid linking objects into multiple modules



On 5/28/2024 9:15 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> Each object file contains information about which module it gets linked
> into, so linking the same file into multiple modules now causes a warning:
> 
> scripts/Makefile.build:254: drivers/net/ethernet/hisilicon/hns3/Makefile: hns3_common/hclge_comm_cmd.o is added to multiple modules: hclge hclgevf
> scripts/Makefile.build:254: drivers/net/ethernet/hisilicon/hns3/Makefile: hns3_common/hclge_comm_rss.o is added to multiple modules: hclge hclgevf
> scripts/Makefile.build:254: drivers/net/ethernet/hisilicon/hns3/Makefile: hns3_common/hclge_comm_tqp_stats.o is added to multiple modules: hclge hclgevf
> 
> Change the way that hns3 is built by moving the three common files into a
> separate module with exported symbols instead.
> 
> Fixes: 5f20be4e90e6 ("net: hns3: refactor hns3 makefile to support hns3_common module")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---

This one has a savings of ~72Kb on my system.

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>