linux-kernel - Re: [PATCH net-next v8 2/2] net: ti: icssg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 30 May 2024 11:15:53 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: MD Danish Anwar <danishanwar@...com>, Jan Kiszka <jan.kiszka@...mens.com>,
	Dan Carpenter <dan.carpenter@...aro.org>, Andrew Lunn <andrew@...n.ch>, Simon
 Horman <horms@...nel.org>, Diogo Ivo <diogo.ivo@...mens.com>, "Wolfram Sang"
	<wsa+renesas@...g-engineering.com>, Randy Dunlap <rdunlap@...radead.org>,
	Niklas Schnelle <schnelle@...ux.ibm.com>, "Vladimir Oltean"
	<vladimir.oltean@....com>, Vignesh Raghavendra <vigneshr@...com>, Richard
 Cochran <richardcochran@...il.com>, Roger Quadros <rogerq@...nel.org>, Paolo
 Abeni <pabeni@...hat.com>, Jakub Kicinski <kuba@...nel.org>, Eric Dumazet
	<edumazet@...gle.com>, "David S. Miller" <davem@...emloft.net>
CC: <linux-arm-kernel@...ts.infradead.org>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <srk@...com>, Roger Quadros <rogerq@...com>
Subject: Re: [PATCH net-next v8 2/2] net: ti: icssg_prueth: add TAPRIO offload
 support



On 5/29/2024 4:05 AM, MD Danish Anwar wrote:
> From: Roger Quadros <rogerq@...com>
> 
> The ICSSG dual-emac / switch firmware supports Enhanced Scheduled Traffic
> (EST – defined in P802.1Qbv/D2.2 that later got included in IEEE
> 802.1Q-2018) configuration. EST allows express queue traffic to be
> scheduled (placed) on the wire at specific repeatable time intervals. In
> Linux kernel, EST configuration is done through tc command and the taprio
> scheduler in the net core implements a software only scheduler
> (SCH_TAPRIO). If the NIC is capable of EST configuration,user indicate
> "flag 2" in the command which is then parsed by taprio scheduler in net
> core and indicate that the command is to be offloaded to h/w. taprio then
> offloads the command to the driver by calling ndo_setup_tc() ndo ops. This
> patch implements ndo_setup_tc() to offload EST configuration to ICSSG.
> 
> Signed-off-by: Roger Quadros <rogerq@...com>
> Signed-off-by: Vignesh Raghavendra <vigneshr@...com>
> Reviewed-by: Simon Horman <horms@...nel.org>
> Signed-off-by: MD Danish Anwar <danishanwar@...com>
> ---

I tried to apply this series to review it. Unfortunately It no longer
applies cleanly since it has textual conflicts with 972383aecf43 ("net:
ti: icssg-switch: Add switchdev based driver for ethernet switch
support"), which was part of:

https://lore.kernel.org/netdev/20240528113734.379422-1-danishanwar@ti.com/

The conflict seemed easy enough to resolve, but I'm not sure if the
prueth_qos structure would be placed optimally. I tried to build the
driver to check what the placement should be and was unable to get
things to compile.