linux-kernel - Re: [PATCH v1 0/2] spi: Make dummy SG handling robust

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VeG9K3Ar4UJnGxus3zz_vtt4QfFdkYQ8=6D8pt2aB8kmA@mail.gmail.com>
Date: Fri, 31 May 2024 18:46:20 +0300
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Nícolas F. R. A. Prado <nfraprado@...labora.com>
Cc: Mark Brown <broonie@...nel.org>, linux-spi@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Neil Armstrong <neil.armstrong@...aro.org>
Subject: Re: [PATCH v1 0/2] spi: Make dummy SG handling robust

On Fri, May 31, 2024 at 5:37 PM Nícolas F. R. A. Prado
<nfraprado@...labora.com> wrote:
> On Fri, May 31, 2024 at 12:44:31PM +0300, Andy Shevchenko wrote:
> > There's an unreliable code to handle DMA mappings on unidirection transfers.
> > This series does two things:
> > - it reverts the seemingly unnecessary change
> > - it reworks dummy SG list handling
> >
> > There is no need to backport that AFAIU, but no harm to apply for v6.10 aka
> > the current release cycle. Guys, please test these.
> >
> > Andy Shevchenko (2):
> >   spi: Revert "Check if transfer is mapped before calling DMA sync APIs"
> >   spi: Do not rely on the SG table and respective API implementations

> Hi Andy,
>
> applying either of these patches causes issues. See the traces for each one
> below. This was tested on top of next-20240531, which works fine.

Oh, thank you very much for prompt testing! Can you test just the
second one without the revert?

So, your patch seems needed for the sync API calls, while I considered
only mapping APIs.

-- 
With Best Regards,
Andy Shevchenko