[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f65c35a9-1b77-41cd-95e0-38ae2e4ced24@intel.com>
Date: Fri, 31 May 2024 11:18:25 -0700
From: Reinette Chatre <reinette.chatre@...el.com>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
<linux-kselftest@...r.kernel.org>, Shuah Khan <shuah@...nel.org>, Babu Moger
<babu.moger@....com>, Maciej Wieczór-Retman
<maciej.wieczor-retman@...el.com>
CC: <linux-kernel@...r.kernel.org>, Fenghua Yu <fenghua.yu@...el.com>, "Shuah
Khan" <skhan@...uxfoundation.org>
Subject: Re: [PATCH v5 16/16] selftests/resctrl: Remove test name comparing
from write_bm_pid_to_resctrl()
Hi Ilpo,
On 5/31/24 6:11 AM, Ilpo Järvinen wrote:
> write_bm_pid_to_resctrl() uses resctrl_val to check test name which is
> not a good interface generic resctrl FS functions should provide.
>
> Tests define mongrp when needed. Remove the test name check in
> write_bm_pid_to_resctrl() to only rely on the mongrp parameter being
> non-NULL.
>
> Remove write_bm_pid_to_resctrl() resctrl_val parameter and resctrl_val
> member from the struct resctrl_val_param that are not used anymore.
> Similarly, remove the test name constants that are no longer used.
>
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> ---
Thank you.
Reviewed-by: Reinette Chatre <reinette.chatre@...el.com>
Reinette
Powered by blists - more mailing lists