linux-kernel - Re: [PATCH 02/12] wifi: wcn36xx: make use of QCOM_FW

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87ed9hvmmy.fsf@kernel.org>
Date: Fri, 31 May 2024 21:53:25 +0300
From: Kalle Valo <kvalo@...nel.org>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc: Bjorn Andersson <andersson@...nel.org>,  Konrad Dybcio
 <konrad.dybcio@...aro.org>,  Loic Poulain <loic.poulain@...aro.org>,
  Mathieu Poirier <mathieu.poirier@...aro.org>,  Rob Herring
 <robh@...nel.org>,  Krzysztof Kozlowski <krzk+dt@...nel.org>,  Conor
 Dooley <conor+dt@...nel.org>,  linux-kernel@...r.kernel.org,
  linux-arm-msm@...r.kernel.org,  wcn36xx@...ts.infradead.org,
  linux-wireless@...r.kernel.org,  linux-remoteproc@...r.kernel.org,
  devicetree@...r.kernel.org,  Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH 02/12] wifi: wcn36xx: make use of QCOM_FW_HELPER

Dmitry Baryshkov <dmitry.baryshkov@...aro.org> writes:

> Make the driver use qcom_fw_helper to autodetect the path to the
> calibration data file.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>

Not a fan of one sentence commit messages. It would be nice to explain a
bit more in the commit message, for instance answering to the question
'why?' and maybe provide a short example how this is supposed to work?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches