[<prev] [next>] [day] [month] [year] [list]
Message-Id: <20240531023115.11940-1-youling.tang@linux.dev>
Date: Fri, 31 May 2024 10:31:15 +0800
From: Youling Tang <youling.tang@...ux.dev>
To: Kent Overstreet <kent.overstreet@...ux.dev>
Cc: Brian Foster <bfoster@...hat.com>,
linux-bcachefs@...r.kernel.org,
linux-kernel@...r.kernel.org,
Youling Tang <tangyouling@...inos.cn>
Subject: [PATCH] bcachefs: track writeback errors using the generic tracking infrastructure
From: Youling Tang <tangyouling@...inos.cn>
We already using mapping_set_error() in bch2_writepage_io_done(), so all
we need to do is to use file_check_and_advance_wb_err() when handling
fsync() requests in bch2_fsync().
Signed-off-by: Youling Tang <tangyouling@...inos.cn>
---
fs/bcachefs/fs-io.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/fs/bcachefs/fs-io.c b/fs/bcachefs/fs-io.c
index ef20b64033e0..f5b266e51261 100644
--- a/fs/bcachefs/fs-io.c
+++ b/fs/bcachefs/fs-io.c
@@ -192,7 +192,7 @@ int bch2_fsync(struct file *file, loff_t start, loff_t end, int datasync)
{
struct bch_inode_info *inode = file_bch_inode(file);
struct bch_fs *c = inode->v.i_sb->s_fs_info;
- int ret;
+ int ret, err;
ret = file_write_and_wait_range(file, start, end);
if (ret)
@@ -205,6 +205,11 @@ int bch2_fsync(struct file *file, loff_t start, loff_t end, int datasync)
ret = bch2_err_class(ret);
if (ret == -EROFS)
ret = -EIO;
+
+ err = file_check_and_advance_wb_err(file);
+ if (!ret)
+ ret = err;
+
return ret;
}
--
2.34.1
Powered by blists - more mailing lists