linux-kernel - Re: [net-next PATCH v2 2/2] net: phy: aquantia: add support for PHY LEDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <25ce6c90-f7c0-4c88-966f-8bbfe59ebde4@lunn.ch>
Date: Fri, 31 May 2024 21:56:28 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Christian Marangi <ansuelsmth@...il.com>
Cc: Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Robert Marko <robimarko@...il.com>,
	Daniel Golle <daniel@...rotopia.org>,
	"Russell King (Oracle)" <rmk+kernel@...linux.org.uk>,
	Paweł Owoc <frut3k7@...il.com>,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [net-next PATCH v2 2/2] net: phy: aquantia: add support for PHY
 LEDs

> +#define AQR_MAX_LEDS				3

> +int aqr_phy_led_brightness_set(struct phy_device *phydev,
> +			       u8 index, enum led_brightness value)
> +{
> +	if (index > 2)
> +		return -EINVAL;

AQR_MAX_LEDS should be used here.

Apart from that:

Reviewed-by: Andrew Lunn <andrew@...n.ch>

pw-bot: cr