linux-kernel - Re: [PATCH net] net: dsa: microchip: fix KSZ9477 set_ageing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <78e2e9b1-e980-4e67-b2a2-352a06619411@lunn.ch>
Date: Fri, 31 May 2024 02:21:35 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Tristram.Ha@...rochip.com
Cc: pabeni@...hat.com, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, UNGLinuxDriver@...rochip.com,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Arun.Ramadoss@...rochip.com, Woojung.Huh@...rochip.com,
	vivien.didelot@...il.com, f.fainelli@...il.com, olteanv@...il.com
Subject: Re: [PATCH net] net: dsa: microchip: fix KSZ9477 set_ageing_time
 function

> > Is the additional accuracy worthy the added complexity WRT:
> > 
> >         mult = DIV_ROUND_UP(secs, 0xff);
> > 
> > ?
> 
> I do not know much accuracy is expected of this function.  I do not know
> whether users can easily specify the amount, but the default is 3 seconds
> which is the same as the hardware default where the multiplier is 4 and
> the count is 75.  So most of the time the rest of the code will not be
> executed.

Are you sure it is 3 seconds?

#define BR_DEFAULT_AGEING_TIME	(300 * HZ)

Fast ageing, after a topology change, is i think 15 seconds.

     Andrew