linux-kernel - Re: [PATCH v3 0/3] selftests/futex: clang-inspired fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 31 May 2024 14:39:41 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: John Hubbard <jhubbard@...dia.com>, Shuah Khan <shuah@...nel.org>
Cc: Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
 Peter Zijlstra <peterz@...radead.org>, Darren Hart <dvhart@...radead.org>,
 Davidlohr Bueso <dave@...olabs.net>, Edward Liaw <edliaw@...gle.com>,
 André Almeida <andrealmeid@...lia.com>,
 "Nysal Jan K . A" <nysal@...ux.ibm.com>, Mark Brown <broonie@...nel.org>,
 Valentin Obst <kernel@...entinobst.de>, linux-kselftest@...r.kernel.org,
 LKML <linux-kernel@...r.kernel.org>, llvm@...ts.linux.dev,
 Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v3 0/3] selftests/futex: clang-inspired fixes

On 5/31/24 14:07, John Hubbard wrote:
> Hi,
> 
> Here's a few fixes that are part of my effort to get all selftests
> building cleanly under clang. Plus one that I noticed by inspection.
> 
> Changes since v2:
> 
> 1) Added a sentence to the .PHONY patch, to show that it is removing
>     duplicate code.
> 
> 2) Added the actual clang warning output to the commit description.
> 
> Changes since the first version:
> 
> 1) Rebased onto Linux 6.10-rc1
> 2) Added Reviewed-by's.
> 
> ...and it turns out that all three patches are still required, on -rc1,
> in order to get a clean clang build.
> 
> Enjoy!
> 
> thanks,
> John Hubbard
> 
> John Hubbard (3):
>    selftests/futex: don't redefine .PHONY targets (all, clean)
>    selftests/futex: don't pass a const char* to asprintf(3)
>    selftests/futex: pass _GNU_SOURCE without a value to the compiler
> 
>   tools/testing/selftests/futex/Makefile                      | 2 --
>   tools/testing/selftests/futex/functional/Makefile           | 2 +-
>   tools/testing/selftests/futex/functional/futex_requeue_pi.c | 2 +-
>   3 files changed, 2 insertions(+), 4 deletions(-)
> 
> 
> base-commit: b050496579632f86ee1ef7e7501906db579f3457

Thank you - applied to linux-kselftest fixes branch for next rc.

thanks,
-- Shuah