linux-kernel - Re: [PATCH v4 1/3] platform/chrome: cros_ec_proto: Introduce cros_ec_cmd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <142a8c0c-7ac8-4033-8c2a-5abb316870e7@roeck-us.net>
Date: Fri, 31 May 2024 14:32:02 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Thomas Weißschuh <linux@...ssschuh.net>,
 Jean Delvare <jdelvare@...e.com>, Benson Leung <bleung@...omium.org>,
 Lee Jones <lee@...nel.org>, Tzung-Bi Shih <tzungbi@...nel.org>
Cc: Guenter Roeck <groeck@...omium.org>, linux-kernel@...r.kernel.org,
 linux-hwmon@...r.kernel.org, chrome-platform@...ts.linux.dev,
 Dustin Howett <dustin@...ett.net>,
 Mario Limonciello <mario.limonciello@....com>,
 Moritz Fischer <mdf@...nel.org>, Stephen Horvath <s.horvath@...look.com.au>,
 Rajas Paranjpe <paranjperajas@...il.com>
Subject: Re: [PATCH v4 1/3] platform/chrome: cros_ec_proto: Introduce
 cros_ec_cmd_readmem()

On 5/28/24 23:27, Thomas Weißschuh wrote:
> To read from the EC memory different mechanism are possible.
> ECs connected via LPC expose their memory via a ->cmd_readmem operation.
> Other protocols require the usage of EC_CMD_READ_MEMMAP, which on the
> other hand is not implemented by LPC ECs.
> 
> Provide a helper that automatically selects the correct mechanism.
> 
> Signed-off-by: Thomas Weißschuh <linux@...ssschuh.net>

Reviewed-by: Guenter Roeck <linux@...ck-us.net>