linux-kernel - Re: [PATCH 1/2] arm64: dts: qcom: sc7180: Disable SS instances in park mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ctmgikoes6p2sbvdxp3jmiseipzqsinbxjg7xewxl5jurh7r7w@s4lxchehtork>
Date: Fri, 31 May 2024 18:02:02 -0500
From: Bjorn Andersson <andersson@...nel.org>
To: Krishna Kurapati <quic_kriskura@...cinc.com>
Cc: cros-qcom-dts-watchers@...omium.org, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Rob Herring <robh@...nel.org>, 
	Konrad Dybcio <konrad.dybcio@...aro.org>, Conor Dooley <conor+dt@...nel.org>, 
	Stephen Boyd <swboyd@...omium.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Matthias Kaehlcke <mka@...omium.org>, linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org, 
	devicetree@...r.kernel.org, quic_ppratap@...cinc.com, quic_jackp@...cinc.com, 
	Doug Anderson <dianders@...gle.com>, stable@...r.kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: qcom: sc7180: Disable SS instances in
 park mode

On Thu, May 30, 2024 at 01:55:55PM GMT, Krishna Kurapati wrote:
> On SC7180, in host mode, it is observed that stressing out controller
> in host mode results in HC died error and only restarting the host

Could you please include a copy of that error message, so that others
searching for that error message will be able to find this commit?

Also, there's three "in host mode"s in this sentence.

> mode fixes it. Disable SS instances in park mode for these targets to

Please spell SS SuperSpeed.

Regards,
Bjorn

> avoid host controller being dead.
> 
> Reported-by: Doug Anderson <dianders@...gle.com>
> Cc: <stable@...r.kernel.org>
> Fixes: 0b766e7fe5a2 ("arm64: dts: qcom: sc7180: Add USB related nodes")
> Signed-off-by: Krishna Kurapati <quic_kriskura@...cinc.com>
> ---
>  arch/arm64/boot/dts/qcom/sc7180.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index 2b481e20ae38..cc93b5675d5d 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -3063,6 +3063,7 @@ usb_1_dwc3: usb@...0000 {
>  				iommus = <&apps_smmu 0x540 0>;
>  				snps,dis_u2_susphy_quirk;
>  				snps,dis_enblslpm_quirk;
> +				snps,parkmode-disable-ss-quirk;
>  				phys = <&usb_1_hsphy>, <&usb_1_qmpphy QMP_USB43DP_USB3_PHY>;
>  				phy-names = "usb2-phy", "usb3-phy";
>  				maximum-speed = "super-speed";
> -- 
> 2.34.1
>