linux-kernel - [PATCH v9 16/24] x86/sev: Drop sev_guest_platform

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 31 May 2024 10:00:30 +0530
From: Nikunj A Dadhania <nikunj@....com>
To: <linux-kernel@...r.kernel.org>, <thomas.lendacky@....com>, <bp@...en8.de>,
	<x86@...nel.org>, <kvm@...r.kernel.org>
CC: <mingo@...hat.com>, <tglx@...utronix.de>, <dave.hansen@...ux.intel.com>,
	<pgonda@...gle.com>, <seanjc@...gle.com>, <pbonzini@...hat.com>,
	<nikunj@....com>
Subject: [PATCH v9 16/24] x86/sev: Drop sev_guest_platform_data structure

SEV guest platform data structure was used to pass the secrets page
physical address. As the SNP guest messaging initialization routines are
local and secrets page address is cached in sev.c, use that instead of
sending it to the SEV guest driver and getting the same address back.

Signed-off-by: Nikunj A Dadhania <nikunj@....com>
---
 arch/x86/include/asm/sev.h              |  9 ++-------
 arch/x86/kernel/sev.c                   | 10 ++--------
 drivers/virt/coco/sev-guest/sev-guest.c |  8 +-------
 3 files changed, 5 insertions(+), 22 deletions(-)

diff --git a/arch/x86/include/asm/sev.h b/arch/x86/include/asm/sev.h
index f58052fd6cb3..128bf71302a3 100644
--- a/arch/x86/include/asm/sev.h
+++ b/arch/x86/include/asm/sev.h
@@ -116,10 +116,6 @@ struct snp_req_data {
 	unsigned long resp_gpa;
 };
 
-struct sev_guest_platform_data {
-	u64 secrets_gpa;
-};
-
 #define VMPCK_MAX_NUM		4
 
 /*
@@ -324,7 +320,7 @@ u64 sev_get_status(void);
 void sev_show_status(void);
 bool snp_assign_vmpck(struct snp_guest_dev *snp_dev, unsigned int vmpck_id);
 bool snp_is_vmpck_empty(struct snp_guest_dev *snp_dev);
-int snp_guest_messaging_init(struct snp_guest_dev *snp_dev, u64 secrets_gpa);
+int snp_guest_messaging_init(struct snp_guest_dev *snp_dev);
 void snp_guest_messaging_exit(struct snp_guest_dev *snp_dev);
 int snp_send_guest_request(struct snp_guest_dev *snp_dev, struct snp_guest_req *req,
 			   struct snp_guest_request_ioctl *rio);
@@ -393,8 +389,7 @@ static inline void sev_show_status(void) { }
 static inline bool snp_assign_vmpck(struct snp_guest_dev *snp_dev,
 				    unsigned int vmpck_id) { return false; }
 static inline bool snp_is_vmpck_empty(struct snp_guest_dev *snp_dev) { return true; }
-static inline int
-snp_guest_messaging_init(struct snp_guest_dev *snp_dev, u64 secrets_gpa) { return -EINVAL; }
+static inline int snp_guest_messaging_init(struct snp_guest_dev *snp_dev) { return -EINVAL; }
 static inline void snp_guest_messaging_exit(struct snp_guest_dev *snp_dev) { }
 static inline int snp_send_guest_request(struct snp_guest_dev *snp_dev, struct snp_guest_req *req,
 					 struct snp_guest_request_ioctl *rio) { return -EINVAL; }
diff --git a/arch/x86/kernel/sev.c b/arch/x86/kernel/sev.c
index 141a670d2a85..c56cb2f15ec7 100644
--- a/arch/x86/kernel/sev.c
+++ b/arch/x86/kernel/sev.c
@@ -2239,15 +2239,9 @@ static struct platform_device sev_guest_device = {
 
 static int __init snp_init_platform_device(void)
 {
-	struct sev_guest_platform_data data;
-
 	if (!cc_platform_has(CC_ATTR_GUEST_SEV_SNP))
 		return -ENODEV;
 
-	data.secrets_gpa = secrets_pa;
-	if (platform_device_add_data(&sev_guest_device, &data, sizeof(data)))
-		return -ENODEV;
-
 	if (platform_device_register(&sev_guest_device))
 		return -ENODEV;
 
@@ -2597,11 +2591,11 @@ int snp_send_guest_request(struct snp_guest_dev *snp_dev,
 }
 EXPORT_SYMBOL_GPL(snp_send_guest_request);
 
-int snp_guest_messaging_init(struct snp_guest_dev *snp_dev, u64 secrets_gpa)
+int snp_guest_messaging_init(struct snp_guest_dev *snp_dev)
 {
 	int ret = -ENOMEM;
 
-	snp_dev->secrets = (__force void *)ioremap_encrypted(secrets_gpa, PAGE_SIZE);
+	snp_dev->secrets = (__force void *)ioremap_encrypted(secrets_pa, PAGE_SIZE);
 	if (!snp_dev->secrets) {
 		pr_err("Failed to map SNP secrets page.\n");
 		return ret;
diff --git a/drivers/virt/coco/sev-guest/sev-guest.c b/drivers/virt/coco/sev-guest/sev-guest.c
index 41878bd968d5..8d026d485028 100644
--- a/drivers/virt/coco/sev-guest/sev-guest.c
+++ b/drivers/virt/coco/sev-guest/sev-guest.c
@@ -406,7 +406,6 @@ static void unregister_sev_tsm(void *data)
 
 static int __init sev_guest_probe(struct platform_device *pdev)
 {
-	struct sev_guest_platform_data *data;
 	struct device *dev = &pdev->dev;
 	struct snp_guest_dev *snp_dev;
 	struct miscdevice *misc;
@@ -415,11 +414,6 @@ static int __init sev_guest_probe(struct platform_device *pdev)
 	if (!cc_platform_has(CC_ATTR_GUEST_SEV_SNP))
 		return -ENODEV;
 
-	if (!dev->platform_data)
-		return -ENODEV;
-
-	data = (struct sev_guest_platform_data *)dev->platform_data;
-
 	snp_dev = devm_kzalloc(&pdev->dev, sizeof(struct snp_guest_dev), GFP_KERNEL);
 	if (!snp_dev)
 		return -ENOMEM;
@@ -430,7 +424,7 @@ static int __init sev_guest_probe(struct platform_device *pdev)
 		return ret;
 	}
 
-	if (snp_guest_messaging_init(snp_dev, data->secrets_gpa)) {
+	if (snp_guest_messaging_init(snp_dev)) {
 		dev_err(dev, "Unable to setup SNP Guest messaging using VMPCK%u\n",
 			snp_dev->vmpck_id);
 		return ret;
-- 
2.34.1