linux-kernel - RE: [EXTERNAL] [PATCH 2/3] net: ti: icss-iep: Enable compare events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: 
 <BY3PR18MB47377FBF88724DD5A4814BCEC6FC2@BY3PR18MB4737.namprd18.prod.outlook.com>
Date: Fri, 31 May 2024 05:12:10 +0000
From: Sunil Kovvuri Goutham <sgoutham@...vell.com>
To: Diogo Ivo <diogo.ivo@...mens.com>, MD Danish Anwar <danishanwar@...com>,
        Roger Quadros <rogerq@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
        Paolo
 Abeni <pabeni@...hat.com>,
        Richard Cochran <richardcochran@...il.com>, Nishanth Menon <nm@...com>,
        Vignesh Raghavendra <vigneshr@...com>,
        Tero
 Kristo <kristo@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof
 Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>,
        Jan
 Kiszka <jan.kiszka@...mens.com>
CC: "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>,
        "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>
Subject: RE: [EXTERNAL] [PATCH 2/3] net: ti: icss-iep: Enable compare events



>-----Original Message-----
>From: Diogo Ivo <diogo.ivo@...mens.com>
>Sent: Wednesday, May 29, 2024 9:35 PM
>To: MD Danish Anwar <danishanwar@...com>; Roger Quadros
><rogerq@...nel.org>; David S. Miller <davem@...emloft.net>; Eric Dumazet
><edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni
><pabeni@...hat.com>; Richard Cochran <richardcochran@...il.com>;
>Nishanth Menon <nm@...com>; Vignesh Raghavendra <vigneshr@...com>;
>Tero Kristo <kristo@...nel.org>; Rob Herring <robh@...nel.org>; Krzysztof
>Kozlowski <krzk+dt@...nel.org>; Conor Dooley <conor+dt@...nel.org>; Jan
>Kiszka <jan.kiszka@...mens.com>
>Cc: linux-arm-kernel@...ts.infradead.org; netdev@...r.kernel.org; linux-
>kernel@...r.kernel.org; devicetree@...r.kernel.org; Diogo Ivo
><diogo.ivo@...mens.com>
>Subject: [EXTERNAL] [PATCH 2/3] net: ti: icss-iep: Enable compare events
>
>The IEP module supports compare events, in which a value is written to a
>hardware register and when the IEP counter reaches the written value an
>interrupt is generated. Add handling for this interrupt in order to support PPS
>events.
>
>Signed-off-by: Diogo Ivo <diogo.ivo@...mens.com>
>---
> 	iep = devm_kzalloc(dev, sizeof(*iep), GFP_KERNEL);
> 	if (!iep)
>@@ -827,6 +883,21 @@ static int icss_iep_probe(struct platform_device
>*pdev)
> 	if (IS_ERR(iep->base))
> 		return -ENODEV;
>
>+	iep->cap_cmp_irq = platform_get_irq_byname_optional(pdev,
>"iep_cap_cmp");
>+	if (iep->cap_cmp_irq < 0) {
>+		if (iep->cap_cmp_irq == -EPROBE_DEFER)
>+			return iep->cap_cmp_irq;

This info is coming from DT, is PROBE_DIFFER error return value possible ?

>+		iep->cap_cmp_irq = 0;
>+	} else {
>+		ret = devm_request_irq(dev, iep->cap_cmp_irq,
>+				       icss_iep_cap_cmp_irq,
>IRQF_TRIGGER_HIGH,
>+				       "iep_cap_cmp", iep);
>+		if (ret)
>+			return dev_err_probe(iep->dev, ret,
>+					     "Request irq failed for cap_cmp\n");

Can't this driver live without this feature ?

>+		INIT_WORK(&iep->work, icss_iep_cap_cmp_work);
>+	}
>+