lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 31 May 2024 09:52:10 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Yasin Lee <yasin.lee.x@...look.com>, jic23@...nel.org
Cc: andy.shevchenko@...il.com, lars@...afoo.de, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org, nuno.a@...log.com, swboyd@...omium.org,
 u.kleine-koenig@...gutronix.de, yasin.lee.x@...il.com
Subject: Re: [PATCH v3 0/2]
 iio-proximity-hx9023s-Add-TYHX-HX9023S-sensor-driver

On 29/05/2024 06:57, Yasin Lee wrote:
> From: Yasin Lee <yasin.lee.x@...il.com>
> 
> v3:
>  - Renamed the files to keep the file names consistent with the chip name.
>  - Removed custom bit operation macro definitions.
>  - Deleted redundant documentation that duplicated the Standard ABI.
>  - Deleted unused header files.
>  - Deleted unused register definitions.
>  - Changed parts of the code related to circuit design to be configurable through DTS.
>  - Removed unnecessary print statements.
>  - Fixed the error in hx9031as_write_event_val.
>  - Removed unnecessary threshold settings in the probe.
>  - Replaced enable_irq(data->client->irq) with interrupt enable register operations.
>  - Fixed style issues.

Please do not ignore comments but respond to them. Go back to 15th of
May and acknowledge all of them. You repeated every single issue...

Best regards,
Krzysztof


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ