linux-kernel - Re: [PATCH 2/2] crypto: hisilicon/zip - optimize the address offset of the reg query function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZlmZh5d8RDo3C-HS@gondor.apana.org.au>
Date: Fri, 31 May 2024 17:33:59 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Chenghai Huang <huangchenghai2@...wei.com>
Cc: davem@...emloft.net, linux-kernel@...r.kernel.org,
	linux-crypto@...r.kernel.org, shenyang39@...wei.com,
	liulongfang@...wei.com, qianweili@...wei.com
Subject: Re: [PATCH 2/2] crypto: hisilicon/zip - optimize the address offset
 of the reg query function

On Mon, May 06, 2024 at 07:59:53PM +0800, Chenghai Huang wrote:
>
> @@ -807,6 +786,18 @@ static int hisi_zip_regs_show(struct seq_file *s, void *unused)
>  
>  DEFINE_SHOW_ATTRIBUTE(hisi_zip_regs);
>  
> +static void __iomem *get_zip_core_addr(struct hisi_qm *qm, int core_num)
> +{
> +	u32 zip_comp_core_num = qm->cap_tables.dev_cap_table[ZIP_CLUSTER_COMP_NUM_CAP_IDX].cap_val;
> +
> +	if (core_num < zip_comp_core_num)
> +		return qm->io_base + HZIP_CORE_DFX_BASE +
> +			(core_num + 1) * HZIP_CORE_ADDR_INTRVL;
> +
> +	qm->io_base + HZIP_CORE_DFX_DECOMP_BASE +
> +		(core_num - zip_comp_core_num) * HZIP_CORE_ADDR_INTRVL;
> +}
> +

This doesn't even build.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt