[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a472e8ba-bf54-4a62-9b05-ea265a83ef1b@kernel.org>
Date: Fri, 31 May 2024 12:19:40 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Animesh Agarwal <animeshagarwal28@...il.com>
Cc: Vinod Koul <vkoul@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
<conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Fabio Estevam <festevam@...il.com>, dmaengine@...r.kernel.org,
devicetree@...r.kernel.org, imx@...ts.linux.dev,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] dt-bindings: dma: fsl,imx-dma: Convert to dtschema
On 31/05/2024 11:04, Animesh Agarwal wrote:
> Convert the fsl i.MX DMA controller bindings to DT schema.
>
> Signed-off-by: Animesh Agarwal <animeshagarwal28@...il.com>
> ---
> .../devicetree/bindings/dma/fsl,imx-dma.yaml | 56 +++++++++++++++++++
Thank you for your patch. There is something to discuss/improve.
> + "#dma-cells":
> + const: 1
> +
> + dma-channels:
> + maximum: 16
maximum or const?
deprecated: true
> +
> + dma-requests:
> + description: Number of DMA requests supported.
deprecated: true
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - "#dma-cells"
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + dma-controller@...01000 {
> + compatible = "fsl,imx27-dma";
> + reg = <0x10001000 0x1000>;
> + interrupts = <32 33>;
> + #dma-cells = <1>;
> + dma-channels = <16>;
and drop it from here
Best regards,
Krzysztof
Powered by blists - more mailing lists