linux-kernel - Re: [PATCH 2/3] hwmon: Add support for SPD5118 compliant temperature sensors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <BA0B79E0-6582-45EA-8EA9-35E278B8CC42@exactcode.de>
Date: Fri, 31 May 2024 12:01:35 +0200
From: René Rebe <rene@...ctcode.de>
To: Wolfram Sang <wsa+renesas@...g-engineering.com>
Cc: Guenter Roeck <linux@...ck-us.net>,
 Thomas Weißschuh <thomas@...ch.de>,
 linux-hwmon@...r.kernel.org,
 Hristo Venev <hristo@...ev.name>,
 Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org,
 Radu Sabau <radu.sabau@...log.com>,
 Paul Menzel <pmenzel@...gen.mpg.de>
Subject: Re: [PATCH 2/3] hwmon: Add support for SPD5118 compliant temperature
 sensors

Hi,

On May 31, 2024, at 11:31, Wolfram Sang <wsa+renesas@...g-engineering.com> wrote:
> 
> Hi all,
> 
>>> Wolfgang seems to think it's important:
> 
> Wolfram, please.
> 
>>> https://lore.kernel.org/lkml/tdia472d4pow2osabef24y2ujkkquplfajxmmtk5pnxllsdxsz@wxzynz7llasr/
>>> 
>> 
>> Ok, but that doesn't explain the reason. Wolfram, Paul, why do you
>> think this is needed ? Note that I am not opposed to adding spd
>> eeprom support, but I'd like to know why I am doing it before
>> I spend time on it.
> 
> A working eeprom driver is needed to get 'decode-dimms' from the
> i2c-tools package working. Jean reported that EEPROM access for DDR5 is
> different from DDR4, so it needs a separate driver. And
> i2c_register_spd() then needs to be updated to use the new driver for
> DDR5.

Well my original downstream driver already had eeprom access:

	https://svn.exactcode.de/t2/trunk/package/kernel/linux/spd-5118.patch

Note there are some surrounding -2, and parity patches around this patch.

Thanks,
	René

--
ExactCODE GmbH, Lietzenburger Str. 42, DE-10789 Berlin
http://exactcode.com | http://exactscan.com | http://ocrkit.com