linux-kernel - Re: [PATCH v10 07/11] Documentation: core-api: Add math.h macros and functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0858f5d9-a694-7ee4-0edf-3f0610703b92@ti.com>
Date: Fri, 31 May 2024 16:27:23 +0530
From: Devarsh Thakkar <devarsht@...com>
To: Randy Dunlap <rdunlap@...radead.org>, <mchehab@...nel.org>,
        <hverkuil-cisco@...all.nl>, <linux-media@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <benjamin.gaignard@...labora.com>,
        <sebastian.fricke@...labora.com>, <akpm@...ux-foundation.org>,
        <gregkh@...uxfoundation.org>, <andriy.shevchenko@...ux.intel.com>,
        <adobriyan@...il.com>, <jani.nikula@...el.com>,
        <p.zabel@...gutronix.de>, <airlied@...il.com>, <daniel@...ll.ch>,
        <dri-devel@...ts.freedesktop.org>, <corbet@....net>,
        <broonie@...nel.org>, <linux-doc@...r.kernel.org>
CC: <laurent.pinchart@...asonboard.com>, <praneeth@...com>, <nm@...com>,
        <vigneshr@...com>, <a-bhatia1@...com>, <j-luthra@...com>,
        <b-brnich@...com>, <detheridge@...com>, <p-mantena@...com>,
        <vijayp@...com>, <andrzej.p@...labora.com>, <nicolas@...fresne.ca>,
        <davidgow@...gle.com>, <dlatypov@...gle.com>
Subject: Re: [PATCH v10 07/11] Documentation: core-api: Add math.h macros and
 functions

Hi Randy,

Thanks for the review.

On 31/05/24 04:14, Randy Dunlap wrote:
> 
> 
> On 5/30/24 10:17 AM, Devarsh Thakkar wrote:
>> Add documentation for rounding, scaling, absolute value and difference,
>> 32-bit division related macros and functions exported by math.h header
>> file.
>>
>> Signed-off-by: Devarsh Thakkar <devarsht@...com>
>> ---
>> V1->V9 (No change)
>> V10: Patch introduced
>> ---
>>  Documentation/core-api/kernel-api.rst | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/core-api/kernel-api.rst b/Documentation/core-api/kernel-api.rst
>> index ae92a2571388..fb467783d491 100644
>> --- a/Documentation/core-api/kernel-api.rst
>> +++ b/Documentation/core-api/kernel-api.rst
>> @@ -185,6 +185,12 @@ Division Functions
>>  .. kernel-doc:: lib/math/gcd.c
>>     :export:
>>  
>> +Rounding, absolute value, scaling and 32bit division functions
> 
>                                          32-bit
> please.
> 

Good catch. Also I see some division functions supporting non-32bit functions
too, so I would make it as below :
Rounding, absolute value, division and 32-bit scaling functions
---------------------------------------------------------------

Regards
Devarsh