linux-kernel - RE: [EXTERNAL] [PATCH net-next 2/2] openvswitch: Remove generic .ndo_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 31 May 2024 13:07:02 +0000
From: Subbaraya Sundeep Bhatta <sbhatta@...vell.com>
To: Breno Leitao <leitao@...ian.org>, Pravin B Shelar <pshelar@....org>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "horms@...nel.org"
	<horms@...nel.org>,
        "open list:OPENVSWITCH" <dev@...nvswitch.org>,
        open list
	<linux-kernel@...r.kernel.org>
Subject: RE: [EXTERNAL] [PATCH net-next 2/2] openvswitch: Remove generic
 .ndo_get_stats64

Hi,

>-----Original Message-----
>From: Breno Leitao <leitao@...ian.org>
>Sent: Friday, May 31, 2024 4:46 PM
>To: Pravin B Shelar <pshelar@....org>; David S. Miller <davem@...emloft.net>;
>Eric Dumazet <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo
>Abeni <pabeni@...hat.com>
>Cc: netdev@...r.kernel.org; horms@...nel.org; open list:OPENVSWITCH
><dev@...nvswitch.org>; open list <linux-kernel@...r.kernel.org>
>Subject: [EXTERNAL] [PATCH net-next 2/2] openvswitch: Remove generic
>.ndo_get_stats64
>
>Commit 3e2f544dd8a33 ("net: get stats64 if device if driver is
>configured") moved the callback to dev_get_tstats64() to net core, so,
>unless the driver is doing some custom stats collection, it does not
>need to set .ndo_get_stats64.
>
>Since this driver is now relying in NETDEV_PCPU_STAT_TSTATS, then, it
>doesn't need to set the dev_get_tstats64() generic .ndo_get_stats64
>function pointer.
>
>Signed-off-by: Breno Leitao <leitao@...ian.org>

Reviewed-by: Subbaraya Sundeep <sbhatta@...vell.com>

Thanks,
Sundeep

>---
> net/openvswitch/vport-internal_dev.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/net/openvswitch/vport-internal_dev.c b/net/openvswitch/vport-
>internal_dev.c
>index 7daba6ac6912..4b33133cbdff 100644
>--- a/net/openvswitch/vport-internal_dev.c
>+++ b/net/openvswitch/vport-internal_dev.c
>@@ -85,7 +85,6 @@ static const struct net_device_ops internal_dev_netdev_ops
>= {
> 	.ndo_stop = internal_dev_stop,
> 	.ndo_start_xmit = internal_dev_xmit,
> 	.ndo_set_mac_address = eth_mac_addr,
>-	.ndo_get_stats64 = dev_get_tstats64,
> };
>
> static struct rtnl_link_ops internal_dev_link_ops __read_mostly = {
>--
>2.43.0
>