linux-kernel - Re: [External] Re: [QUESTION] mm: Redundant const parameter?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZlnOtboo8mpWVBxR@casper.infradead.org>
Date: Fri, 31 May 2024 14:20:53 +0100
From: Matthew Wilcox <willy@...radead.org>
To: Chengming Zhou <zhouchengming@...edance.com>
Cc: Dev Jain <dev.jain@....com>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, Anshuman.Khandual@....com
Subject: Re: [External] Re: [QUESTION] mm: Redundant const parameter?

On Fri, May 31, 2024 at 08:30:08PM +0800, Chengming Zhou wrote:
> On 2024/5/31 19:31, Dev Jain wrote:
> > I guess it would be better if I send this as a patch and wait for comments.
> 
> Ah, you're right. I think it should be:
> 
> 	return folio_test_workingset(slab_folio(slab));
> 
> Right? Don't notice there isn't any build warning about this "const" discard.

But there used to be!  I fixed that in ce3467af6bde dated Feb 27 2024,
which took a fair amount of prep work to make happen.