linux-kernel - Re: [v4,1/2] drm/bridge: sii902x: Fix mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240531133324.GA1715839@ravnborg.org>
Date: Fri, 31 May 2024 15:33:24 +0200
From: Sam Ravnborg <sam@...nborg.org>
To: Sui Jingfeng <sui.jingfeng@...ux.dev>,
	Jayesh Choudhary <j-choudhary@...com>
Cc: Jayesh Choudhary <j-choudhary@...com>, linux-kernel@...r.kernel.org,
	dmitry.baryshkov@...aro.org, andrzej.hajda@...el.com,
	neil.armstrong@...aro.org, rfoss@...nel.org,
	Laurent.pinchart@...asonboard.com, mripard@...nel.org,
	jonas@...boo.se, jernej.skrabec@...il.com,
	maarten.lankhorst@...ux.intel.com, tzimmermann@...e.de,
	airlied@...il.com, daniel@...ll.ch, a-bhatia1@...com,
	dri-devel@...ts.freedesktop.org
Subject: Re: [v4,1/2] drm/bridge: sii902x: Fix mode_valid hook

Hi Jayesh,

> > +
> >   static const struct drm_bridge_funcs sii902x_bridge_funcs = {
> >   	.attach = sii902x_bridge_attach,
> >   	.mode_set = sii902x_bridge_mode_set,
> > @@ -516,6 +529,7 @@ static const struct drm_bridge_funcs sii902x_bridge_funcs = {
> >   	.atomic_destroy_state = drm_atomic_helper_bridge_destroy_state,
> >   	.atomic_get_input_bus_fmts = sii902x_bridge_atomic_get_input_bus_fmts,
> >   	.atomic_check = sii902x_bridge_atomic_check,
> > +	.mode_valid = sii902x_bridge_mode_valid,

As you have the possibility to test the driver, it would be nice with a
follow-up patch that replaces the use of enable() / disable() with the
atomic counterparts.

enable() / disable() are deprecated, so it is nice to reduce their use.

	Sam