linux-kernel - Re: [PATCH 2/3] hwmon: Add support for SPD5118 compliant temperature sensors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6e161edf-db95-421b-9df7-fe23be411536@roeck-us.net>
Date: Fri, 31 May 2024 06:55:00 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: René Rebe <rene@...ctcode.de>
Cc: Wolfram Sang <wsa+renesas@...g-engineering.com>,
 Thomas Weißschuh <thomas@...ch.de>,
 linux-hwmon@...r.kernel.org, Hristo Venev <hristo@...ev.name>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, Radu Sabau <radu.sabau@...log.com>,
 Paul Menzel <pmenzel@...gen.mpg.de>
Subject: Re: [PATCH 2/3] hwmon: Add support for SPD5118 compliant temperature
 sensors

On 5/31/24 06:20, René Rebe wrote:
> Hi,
> 
>> On May 31, 2024, at 15:14, Guenter Roeck <linux@...ck-us.net> wrote:
>>
>> Hi René,
>>
>> On 5/31/24 03:01, René Rebe wrote:
>>> Hi,
>>> On May 31, 2024, at 11:31, Wolfram Sang <wsa+renesas@...g-engineering.com> wrote:
>>>>
>>>> Hi all,
>>>>
>>>>>> Wolfgang seems to think it's important:
>>>>
>>>> Wolfram, please.
>>>>
>>>>>> https://lore.kernel.org/lkml/tdia472d4pow2osabef24y2ujkkquplfajxmmtk5pnxllsdxsz@wxzynz7llasr/
>>>>>>
>>>>>
>>>>> Ok, but that doesn't explain the reason. Wolfram, Paul, why do you
>>>>> think this is needed ? Note that I am not opposed to adding spd
>>>>> eeprom support, but I'd like to know why I am doing it before
>>>>> I spend time on it.
>>>>
>>>> A working eeprom driver is needed to get 'decode-dimms' from the
>>>> i2c-tools package working. Jean reported that EEPROM access for DDR5 is
>>>> different from DDR4, so it needs a separate driver. And
>>>> i2c_register_spd() then needs to be updated to use the new driver for
>>>> DDR5.
>>> Well my original downstream driver already had eeprom access:
>>> https://svn.exactcode.de/t2/trunk/package/kernel/linux/spd-5118.patch
>>
>> Yes, but you didn't send it upstream, so I took it, fixed a couple of bugs,
> 
> And I appreciate that!
> 
>> dropped eeprom support since that is secondary for my use case as well as the
> 
> I only said the original code had this implemented if someone wants to re-add it
> to save them some time not having to re-write it from scratch ;-)
> 

That is for sure what I had planned to do.

>> out-of-tree parity code, and submitted it. I'd be more than happy to let you
>> take over if you like.
> 
> I’m mostly out of time, so I appreciate you starting the upstream process.
> 

Ok, I'll keep going.

Thanks,
Guenter