linux-kernel - Re: [PATCH 2/2] selftests/lib.mk: silence some clang warnings that gcc already ignores

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e9597e75-948b-4ddc-8ca3-e9b188099f8f@linuxfoundation.org>
Date: Fri, 31 May 2024 08:30:27 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: John Hubbard <jhubbard@...dia.com>, Shuah Khan <shuah@...nel.org>
Cc: Beau Belgrave <beaub@...ux.microsoft.com>,
 Steven Rostedt <rostedt@...dmis.org>, Mark Brown <broonie@...nel.org>,
 Naresh Kamboju <naresh.kamboju@...aro.org>,
 Nick Desaulniers <ndesaulniers@...gle.com>,
 Justin Stitt <justinstitt@...gle.com>, Bill Wendling <morbo@...gle.com>,
 sunliming <sunliming@...inos.cn>, Masami Hiramatsu <mhiramat@...nel.org>,
 Valentin Obst <kernel@...entinobst.de>, linux-kselftest@...r.kernel.org,
 LKML <linux-kernel@...r.kernel.org>, llvm@...ts.linux.dev,
 Nathan Chancellor <nathan@...nel.org>, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH 2/2] selftests/lib.mk: silence some clang warnings that
 gcc already ignores

On 5/30/24 13:28, John Hubbard wrote:
> On 5/30/24 7:25 AM, Shuah Khan wrote:
>> On 5/28/24 20:08, John Hubbard wrote:
>>> gcc defaults to silence (off) for the following warnings, but clang
>>> defaults to the opposite. These warnings are not useful for kselftests,
>>> so silence them for the clang builds as well:
>>
>> Please you add more information on why they aren't useful
>> for kselftests.
> 
> Ah OK. My wording is a little misleading. The warnings are not useful
> for the *kernel*, as previous decided by the gcc settings when building
> the kernel. And it is only only due to including kernel data structures
> in the selftests, that we get the warnings on clang.
> 
> So it is not something unique to the selftests. There is nothing that
> the selftests' code does that triggers these warnings, other than the
> act of including the kernel's data structures.
> 
> I can post a v2 to update both the comment and the commit description.
> 
  
Yes please.

thanks,
-- Shuah