linux-kernel - Re: (subset) [PATCH 1/1] leds: ss4200: Convert PCIBIOS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 31 May 2024 16:05:36 +0100
From: Lee Jones <lee@...nel.org>
To: Pavel Machek <pavel@....cz>, Lee Jones <lee@...nel.org>, 
 Dave Hansen <dave@...1.net>, Richard Purdie <rpurdie@...ux.intel.com>, 
 linux-leds@...r.kernel.org, linux-kernel@...r.kernel.org, 
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: stable@...r.kernel.org
Subject: Re: (subset) [PATCH 1/1] leds: ss4200: Convert PCIBIOS_* return
 codes to errnos

On Mon, 27 May 2024 16:27:00 +0300, Ilpo Järvinen wrote:
> ich7_lpc_probe() uses pci_read_config_dword() that returns PCIBIOS_*
> codes. The error handling code assumes incorrectly it's a normal errno
> and checks for < 0. The return code is returned from the probe function
> as is but probe functions should return normal errnos.
> 
> Remove < 0 from the check and convert PCIBIOS_* returns code using
> pcibios_err_to_errno() into normal errno before returning it.
> 
> [...]

Applied, thanks!

[1/1] leds: ss4200: Convert PCIBIOS_* return codes to errnos
      commit: c1f69631a8f438997621c9ff322452b744525048

--
Lee Jones [李琼斯]