linux-kernel - Re: [PATCH] serial: sc16is7xx: set driver name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bc4d9470-340c-4559-b56f-7cce89c45d0b@zonque.org>
Date: Fri, 31 May 2024 17:12:55 +0200
From: Daniel Mack <daniel@...que.org>
To: Greg KH <gregkh@...uxfoundation.org>
Cc: hvilleneuve@...onoff.com, linux-serial@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] serial: sc16is7xx: set driver name

On 5/31/24 12:27, Greg KH wrote:
> On Fri, May 31, 2024 at 12:19:59PM +0200, Daniel Mack wrote:
>> Set the drv_name field of the driver struct so that the tty core
>> registers a procfs entry for it. This is useful for debugging.
>>
>> Signed-off-by: Daniel Mack <daniel@...que.org>
>> ---
>>  drivers/tty/serial/sc16is7xx.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
>> index bf0065d1c8e9..308edbacda7b 100644
>> --- a/drivers/tty/serial/sc16is7xx.c
>> +++ b/drivers/tty/serial/sc16is7xx.c
>> @@ -351,6 +351,7 @@ static struct uart_driver sc16is7xx_uart = {
>>  	.owner		= THIS_MODULE,
>>  	.driver_name    = SC16IS7XX_NAME,
>>  	.dev_name	= "ttySC",
>> +	.driver_name	= SC16IS7XX_NAME,
> 
> Are you sure this patch is correct?  Look 2 lines up :)
> 

Oh, Hugo did that already. Sorry for the noise.


Daniel