linux-kernel - Re: [PATCH] staging: r8712u: remove unused struct 'zero_bulkout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7e64f57e-7f49-4681-9b3b-2d8fe2e0f5ce@gmail.com>
Date: Sat, 1 Jun 2024 16:50:25 +0200
From: Philipp Hortmann <philipp.g.hortmann@...il.com>
To: "Dr. David Alan Gilbert" <linux@...blig.org>
Cc: Larry.Finger@...inger.net, florian.c.schilhabel@...glemail.com,
 gregkh@...uxfoundation.org, linux-staging@...ts.linux.dev,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: r8712u: remove unused struct
 'zero_bulkout_context'

On 6/1/24 15:17, Dr. David Alan Gilbert wrote:
> * Philipp Hortmann (philipp.g.hortmann@...il.com) wrote:
>> On 5/29/24 02:08, linux@...blig.org wrote:
>>
>> please remove the following line:
>>> From: "Dr. David Alan Gilbert" <linux@...blig.org>
>>>
>> To me it is not important which commit introduced the struct. This is not a
>> bug. So I would omit this lines and use instead just:
>> Remove struct zero_bulkout_context as it is unused.
>>> 'zero_bulkout_context' is unused since the original
>>> commit 2865d42c78a9 ("staging: r8712u: Add the new driver to the
>>> mainline kernel").
>>>
>> please remove the following line:
>>> Remove it. >
> 
> v2 sent just now with changes as requested.
> (Although I think you're the only person who has asked
> to remove that detail, most seem to like it as a hint
> as to whether there's some reason it's unused).
> 
> Dave

May be you are right. But may be they are just happy that they do not 
have to respond to mails for the drivers named in this email:
https://lore.kernel.org/linux-staging/623629d4-87ad-4e7d-b4f7-2d10e0c02a2d@gmail.com/
Please consider that reviewers and testers are always wanted.

That only one person responses for simple changes is not so uncommon.

Thanks for your support.

Philipp



> 
>>> Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
>>> ---
>>>    drivers/staging/rtl8712/usb_ops_linux.c | 7 -------
>>>    1 file changed, 7 deletions(-)
>>>
>>> diff --git a/drivers/staging/rtl8712/usb_ops_linux.c b/drivers/staging/rtl8712/usb_ops_linux.c
>>> index b2181e1e2d38..0a3451cdc8a1 100644
>>> --- a/drivers/staging/rtl8712/usb_ops_linux.c
>>> +++ b/drivers/staging/rtl8712/usb_ops_linux.c
>>> @@ -26,13 +26,6 @@
>>>    #define	RTL871X_VENQT_READ	0xc0
>>>    #define	RTL871X_VENQT_WRITE	0x40
>>> -struct zero_bulkout_context {
>>> -	void *pbuf;
>>> -	void *purb;
>>> -	void *pirp;
>>> -	void *padapter;
>>> -};
>>> -
>>>    uint r8712_usb_init_intf_priv(struct intf_priv *pintfpriv)
>>>    {
>>>    	pintfpriv->piorw_urb = usb_alloc_urb(0, GFP_ATOMIC);
>>
>>
>> Hi David,
>>
>> I would prefer the following changes:
>> Subject: please change from r8712u which is the compiled driver name to
>> folder name of the driver: rtl8712
>>
>> Please also consider the above hints.
>>
>> If you send in a second version of this patch please use a change history.
>> Description from Dan under:
>> https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/
>>
>> Please contact me for any questions.
>>
>> Thanks for your support.
>>
>> Bye Philipp
>>
>>
>>