linux-kernel - Re: [PATCH RFT v3 4/4] hwmon: (spd5118) Add support for reading SPD data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4cc979c3-3ce0-4f31-b5d0-508e1af5fdf4@roeck-us.net>
Date: Fri, 31 May 2024 22:42:24 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: linux-hwmon@...r.kernel.org
Cc: devicetree@...r.kernel.org, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, linux-kernel@...r.kernel.org,
 Armin Wolf <W_Armin@....de>, Thomas Weißschuh
 <linux@...ssschuh.net>, René Rebe <rene@...ctcode.de>,
 Wolfram Sang <wsa+renesas@...g-engineering.com>
Subject: Re: [PATCH RFT v3 4/4] hwmon: (spd5118) Add support for reading SPD
 data

On 5/31/24 16:05, Guenter Roeck wrote:
> Add support for reading SPD NVRAM data from SPD5118 (Jedec JESD300)
> compliant memory modules. NVRAM write operation is not supported.
> 
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> ---
> v3: New patch
> 
> RFT: I'd like to get some more test coverage before moving forward
>       with this patch. decode-dimms doesn't recognize the 'spd5118'
>       driver.
> 

Looking for feedback:

[ ... ]

> +
> +	nvmem = devm_nvmem_register(dev, &nvmem_config);

This returns ERR_PTR(-EOPNOTSUPP) if CONFIG_NVRAM=n. We have two options:

- Ignore -EOPNOTSUPP and continue registering the hwmon device

or

- Add
	select NVRAM
	select NVRAM_SYSFS
   to the driver's Kconfig entry.

Any preferences ?
	
Thanks,
Guenter