linux-kernel - Re: [PATCH] iio: dac: ad9739a: drop COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240602131408.08fb15d8@jic23-huawei>
Date: Sun, 2 Jun 2024 13:14:08 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Nuno Sá <noname.nuno@...il.com>
Cc: Arnd Bergmann <arnd@...db.de>, Arnd Bergmann <arnd@...nel.org>,
 Lars-Peter Clausen <lars@...afoo.de>, Nuno Sá
 <nuno.sa@...log.com>, Dragos Bogdan <dragos.bogdan@...log.com>, Anshul
 Dalal <anshulusr@...il.com>, Andrea Collamati <andrea.collamati@...il.com>,
 linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: dac: ad9739a: drop COMPILE_TEST option

On Wed, 29 May 2024 10:09:28 +0200
Nuno Sá <noname.nuno@...il.com> wrote:

> On Wed, 2024-05-29 at 09:23 +0200, Arnd Bergmann wrote:
> > On Wed, May 29, 2024, at 09:20, Nuno Sá wrote:  
> > > On Tue, 2024-05-28 at 14:12 +0200, Arnd Bergmann wrote:  
> > > > From: Arnd Bergmann <arnd@...db.de>
> > > > 
> > > > Build testing without SPI results in a warning:
> > > > 
> > > > WARNING: unmet direct dependencies detected for REGMAP_SPI
> > > >   Depends on [n]: SPI [=n]
> > > >   Selected by [m]:
> > > >   - AD9739A [=m] && IIO [=m] && (SPI [=n] || COMPILE_TEST [=y])
> > > > 
> > > > There is no need for this particular COMPILE_TEST option, as allmodconfig
> > > > and randconfig testing can just assume that SPI is enabled separately.
> > > > 
> > > > Drop it to avoid the warning.
> > > > 
> > > > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> > > > ---  
> > > 
> > > Reviewed-by: Nuno Sa <nuno.sa@...log.com>
> > > 
> > > Only for my understanding. When does COMPILE_TEST makes sense to add?  
> > 
> > The most common use is to enable building a driver
> > that is platform specific on x86 allmodconfig
> > or on randconfig, e.g.
> > 
> > config LPC18XX_DAC
> >         tristate "NXP LPC18xx DAC driver"
> >         depends on ARCH_LPC18XX || COMPILE_TEST
> >         depends on HAS_IOMEM
> > 
> > Since ARCH_LPC18XX is only visible on arch/arm, the
> > driver would never be build tested on anything else
> > without the ||COMPILE_TEST.  
> 
> Makes sense... Thanks!
> 
> - Nuno Sá
> 

Applied. Thanks