linux-kernel - Re: [PATCH v7 3/4] perf annotate: LLVM-based disassembler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZlzYUjBJzlERP37P@google.com>
Date: Sun, 2 Jun 2024 22:38:42 +0200
From: "Steinar H. Gunderson" <sesse@...gle.com>
To: Namhyung Kim <namhyung@...nel.org>
Cc: acme@...nel.org, linux-perf-users@...r.kernel.org,
	linux-kernel@...r.kernel.org, irogers@...gle.com
Subject: Re: [PATCH v7 3/4] perf annotate: LLVM-based disassembler

On Tue, May 28, 2024 at 09:06:24PM -0700, Namhyung Kim wrote:
>> +       struct symbol_lookup_storage *storage =
>> +               (struct symbol_lookup_storage *)disinfo;
> You don't need this in C. :)  Also we usually put a blank line
> after declaration (at least, at the beginning).

Done.

> We put the arguments at the same line and align them.
> Please do the same in other places.

Done, I believe.

>> +       LLVMDisasmDispose(disasm);
>> +       free(buf);
>> +       free(line_storage);
>> +       return 0;
> Often we just set a different return value here and share the
> error handling logic at the end.

Done.

/* Steinar */