linux-kernel - Re: [PATCH 2/2] power: supply: samsung-sdi-battery: Constify struct power_supply_maintenance_charge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dgkqcnvnrw3sxzojjsteqpudf4sfjhsd6ifvwzn7murxeajs4w@2qededvny4vy>
Date: Mon, 3 Jun 2024 00:59:38 +0200
From: Sebastian Reichel <sebastian.reichel@...labora.com>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org, 
	linux-pm@...r.kernel.org
Subject: Re: [PATCH 2/2] power: supply: samsung-sdi-battery: Constify struct
 power_supply_maintenance_charge_table

Hello,

On Sat, Jun 01, 2024 at 05:00:29PM +0200, Christophe JAILLET wrote:
> 'struct power_supply_maintenance_charge_table' is not modified in this
> driver.
> 
> Constifying this structure moves some data to a read-only section, so
> increase overall security.
> 
> In order to do it, some code also needs to be adjusted to this new const
> qualifier.
> 
> On a x86_64, with allmodconfig:
> Before:
> ======
> $ size drivers/power/supply/samsung-sdi-battery.o
>    text	   data	    bss	    dec	    hex	filename
>    4055	   4584	      0	   8639	   21bf	drivers/power/supply/samsung-sdi-battery.o
> 
> After:
> =====
> $ size drivers/power/supply/samsung-sdi-battery.o
>    text	   data	    bss	    dec	    hex	filename
>    4087	   4552	      0	   8639	   21bf	drivers/power/supply/samsung-sdi-battery.o
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
> Compile tested-only
> ---

Looks like that compile testing did not include ab8500_chargalg :)
Fixing the error reported by the Intel bot should be trivial (i.e.
add another const). When you send a new version, please also Cc
Linus Walleij <linus.walleij@...aro.org>.

Thanks for your patches and greetings,

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)