linux-kernel - Re: [PATCH 9/9] mmc: Convert from tasklet to BH workqueue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <61F36002-C765-410C-8EF9-203593C269FF@linux.microsoft.com>
Date: Mon, 3 Jun 2024 10:25:02 -0700
From: Allen Pais <apais@...ux.microsoft.com>
To: Aubin Constans <aubin.constans@...rochip.com>
Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
 Tejun Heo <tj@...nel.org>,
 Kees Cook <keescook@...omium.org>,
 Vinod Koul <vkoul@...nel.org>,
 marcan@...can.st,
 sven@...npeter.dev,
 florian.fainelli@...adcom.com,
 Ray Jui <rjui@...adcom.com>,
 Scott Branden <sbranden@...adcom.com>,
 Paul Cercueil <paul@...pouillou.net>,
 Eugeniy.Paltsev@...opsys.com,
 manivannan.sadhasivam@...aro.org,
 Viresh Kumar <vireshk@...nel.org>,
 Frank.Li@....com,
 Leo Li <leoyang.li@....com>,
 zw@...kernel.org,
 Zhou Wang <wangzhou1@...ilicon.com>,
 haijie1@...wei.com,
 Shawn Guo <shawnguo@...nel.org>,
 Sascha Hauer <s.hauer@...gutronix.de>,
 Sean Wang <sean.wang@...iatek.com>,
 Matthias Brugger <matthias.bgg@...il.com>,
 angelogioacchino.delregno@...labora.com,
 Andreas Färber <afaerber@...e.de>,
 Logan Gunthorpe <logang@...tatee.com>,
 Daniel Mack <daniel@...que.org>,
 Haojian Zhuang <haojian.zhuang@...il.com>,
 Robert Jarzmik <robert.jarzmik@...e.fr>,
 andersson@...nel.org,
 konrad.dybcio@...aro.org,
 Orson Zhai <orsonzhai@...il.com>,
 baolin.wang@...ux.alibaba.com,
 Lyra Zhang <zhang.lyra@...il.com>,
 Patrice CHOTARD <patrice.chotard@...s.st.com>,
 Linus Walleij <linus.walleij@...aro.org>,
 Chen-Yu Tsai <wens@...e.org>,
 Jernej Škrabec <jernej.skrabec@...il.com>,
 peter.ujfalusi@...il.com,
 kys@...rosoft.com,
 haiyangz@...rosoft.com,
 wei.liu@...nel.org,
 decui@...rosoft.com,
 jassisinghbrar@...il.com,
 mchehab@...nel.org,
 maintainers@...echerrydvr.com,
 ulf.hansson@...aro.org,
 manuel.lauss@...il.com,
 mirq-linux@...e.qmqm.pl,
 jh80.chung@...sung.com,
 oakad@...oo.com,
 hayashi.kunihiko@...ionext.com,
 mhiramat@...nel.org,
 brucechang@....com.tw,
 HaraldWelte@...tech.com,
 pierre@...man.eu,
 duncan.sands@...e.fr,
 stern@...land.harvard.edu,
 oneukum@...e.com,
 openipmi-developer@...ts.sourceforge.net,
 dmaengine@...r.kernel.org,
 asahi@...ts.linux.dev,
 linux-arm-kernel@...ts.infradead.org,
 linux-rpi-kernel@...ts.infradead.org,
 linux-mips@...r.kernel.org,
 imx@...ts.linux.dev,
 linuxppc-dev@...ts.ozlabs.org,
 linux-mediatek@...ts.infradead.org,
 linux-actions@...ts.infradead.org,
 linux-arm-msm@...r.kernel.org,
 linux-riscv@...ts.infradead.org,
 linux-sunxi@...ts.linux.dev,
 linux-tegra@...r.kernel.org,
 linux-hyperv@...r.kernel.org,
 linux-rdma@...r.kernel.org,
 linux-media@...r.kernel.org,
 linux-mmc@...r.kernel.org,
 linux-omap@...r.kernel.org,
 linux-renesas-soc@...r.kernel.org,
 linux-s390@...r.kernel.org,
 netdev@...r.kernel.org,
 linux-usb@...r.kernel.org
Subject: Re: [PATCH 9/9] mmc: Convert from tasklet to BH workqueue



> On Jun 3, 2024, at 5:38 AM, Aubin Constans <aubin.constans@...rochip.com> wrote:
> 
> On 27/03/2024 17:03, Allen Pais wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>> The only generic interface to execute asynchronously in the BH context is
>> tasklet; however, it's marked deprecated and has some design flaws. To
>> replace tasklets, BH workqueue support was recently added. A BH workqueue
>> behaves similarly to regular workqueues except that the queued work items
>> are executed in the BH context.
>> This patch converts drivers/infiniband/* from tasklet to BH workqueue.
>> Based on the work done by Tejun Heo <tj@...nel.org>
>> Branch: https://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git for-6.10
>> Signed-off-by: Allen Pais <allen.lkml@...il.com>
>> ---
>>  drivers/mmc/host/atmel-mci.c                  | 35 ++++-----
> [...]
> 
> For atmel-mci, judging from a few simple tests, performance is preserved.
> E.g. writing to a SD Card on the SAMA5D3-Xplained board:
> time dd if=/dev/zero of=/opt/_del_me bs=4k count=64k
> 
>     Base 6.9.0 : 0.07user 5.05system 0:18.92elapsed 27%CPU
>  Patched 6.9.0+: 0.12user 4.92system 0:18.76elapsed 26%CPU
> 
> However, please resolve what checkpatch is complaining about:
> scripts/checkpatch.pl --strict PATCH-9-9-mmc-Convert-from-tasklet-to-BH-workqueue.mbox
> 
>  WARNING: please, no space before tabs
>  #72: FILE: drivers/mmc/host/atmel-mci.c:367:
>  +^Istruct work_struct ^Iwork;$
> 
> Same as discussions on the USB patch[1] and others in this series, I am also in favour of "workqueue" or similar in the comments, rather than just "work".

 Will send out a new version.

Thank you very much for testing and providing your review.

- Allen

> 
> Apart from that:
> Tested-by: Aubin Constans <aubin.constans@...rochip.com>
> Acked-by: Aubin Constans <aubin.constans@...rochip.com>
> 
> Thanks.
> 
> [1]: https://lore.kernel.org/linux-mmc/CAOMdWSLipPfm3OZTpjZz4uF4M+E_8QAoTeMcKBXawLnkTQx6Jg@mail.gmail.com/