[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87o78h266y.fsf@jubnut.com>
Date: Mon, 03 Jun 2024 20:10:29 +0100
From: Ben Walsh <ben@...nut.com>
To: Mario Limonciello <mario.limonciello@....com>, Tzung-Bi Shih
<tzungbi@...nel.org>
Cc: Benson Leung <bleung@...omium.org>, Guenter Roeck <groeck@...omium.org>,
"Dustin L. Howett" <dustin@...ett.net>, Kieran Levin <ktl@...me.work>,
Thomas Weißschuh <linux@...ssschuh.net>,
chrome-platform@...ts.linux.dev,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/5] platform/chrome: cros_ec_lpc: Add a new quirk
for ACPI id
Mario Limonciello <mario.limonciello@....com> writes:
> On 6/3/2024 04:30, Tzung-Bi Shih wrote:
>> On Mon, Jun 03, 2024 at 07:38:32AM +0100, Ben Walsh wrote:
>>> @@ -436,6 +463,8 @@ static int cros_ec_lpc_probe(struct platform_device *pdev)
>>>
>>> ec_lpc->mmio_memory_base = EC_LPC_ADDR_MEMMAP;
>>>
>>> + adev = ACPI_COMPANION(dev);
>>> +
>>
>> The change is irrelevant to the patch.
>
> It looks relevant to me. The companion needs to get set before the
> quirk overwrites it.
That was my thinking. You can either update "adev" and use it to refer
to the ACPI companion device, or (as Tzung-Bi suggests) use
"ACPI_COMPANION" / "ACPI_COMPANION_SET" as needed.
I really don't mind either way. I'm happy to change it if necessary.
Powered by blists - more mailing lists