linux-kernel - Re: [PATCH] Convert __unmap_hugepage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOzc2pzvWaqkHLCMfQ=oMggVSDU7+0do1+u0BndbS2ijVeEZ5A@mail.gmail.com>
Date: Mon, 3 Jun 2024 12:38:47 -0700
From: Vishal Moola <vishal.moola@...il.com>
To: Matthew Wilcox <willy@...radead.org>
Cc: linux-mm@...ck.org, akpm@...ux-foundation.org, muchun.song@...ux.dev, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Convert __unmap_hugepage_range() to folios

On Tue, May 21, 2024 at 2:13 PM Vishal Moola <vishal.moola@...il.com> wrote:
>
> On Mon, May 20, 2024 at 2:46 PM Matthew Wilcox <willy@...radead.org> wrote:
> >
> > On Mon, May 20, 2024 at 12:47:49PM -0700, Vishal Moola (Oracle) wrote:
> > > Replaces 4 calls to compound_head() with one. Also converts
> > > unmap_hugepage_range() and unmap_ref_private() to take in folios.
> >
> > This is great!
> >
> > >  void __unmap_hugepage_range(struct mmu_gather *tlb, struct vm_area_struct *vma,
> > >                           unsigned long start, unsigned long end,
> > > -                         struct page *ref_page, zap_flags_t zap_flags)
> > > +                         struct folio *ref_folio, zap_flags_t zap_flags)
> > >  {
> > >       struct mm_struct *mm = vma->vm_mm;
> > >       unsigned long address;
> > >       pte_t *ptep;
> > >       pte_t pte;
> > >       spinlock_t *ptl;
> > > -     struct page *page;
> > > +     struct folio *folio;
> > >       struct hstate *h = hstate_vma(vma);
> > >       unsigned long sz = huge_page_size(h);
> >
> > I would appreciate some further cleanup ...
> >
> >         size_t sz = folio_size(folio);
> >
> > I think there are further cleanups along those lines, eg
> > pages_per_huge_page(), hugetlb_mask_last_page(), huge_page_mask().
> >
>
> Gotcha, I'll look into those and change them in v2.

I took a closer look at your suggestions for cleanups here. Most callers of
unmap_hugepage_range() pass NULL as ref_folio - meaning we want to unmap
all pages in the range. This means alot of the preparatory work is
likely done without
a reference to a folio, so using folio_size() is unsafe.

For when we later have a reference to a folio, I think we should
continue to use the
hstate-defined values since using the folio in one place and hstate in
another makes
things harder to change (if we ever want to).