linux-kernel - Re: [PATCH v1 0/8] spi: Rework DMA mapped flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e9f6e8fe-7147-4caf-a7fc-e612069c2eaf@notapiano>
Date: Mon, 3 Jun 2024 15:49:04 -0400
From: Nícolas F. R. A. Prado <nfraprado@...labora.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Mark Brown <broonie@...nel.org>,
	Yang Yingliang <yangyingliang@...wei.com>,
	Christophe JAILLET <christophe.jaillet@...adoo.fr>,
	Thangaraj Samynathan <thangaraj.s@...rochip.com>,
	linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-arm-msm@...r.kernel.org,
	Serge Semin <fancer.lancer@...il.com>,
	Daniel Mack <daniel@...que.org>,
	Haojian Zhuang <haojian.zhuang@...il.com>,
	Robert Jarzmik <robert.jarzmik@...e.fr>,
	Neil Armstrong <neil.armstrong@...aro.org>
Subject: Re: [PATCH v1 0/8] spi: Rework DMA mapped flag

On Fri, May 31, 2024 at 10:42:32PM +0300, Andy Shevchenko wrote:
> The first part of the series (patches 1 to 7) is an introduction
> of a new helper followed by the user conversion.
> 
> This consolidates the same code and also makes patch 8 (last one)
> be localised to the SPI core part.
> 
> The last patch is the main rework to get rid of a recently introduced
> hack with a dummy SG list and move to the transfer-based DMA mapped
> flag. 
> 
> That said, the patches 1 to 7 may be applied right away since they
> have no functional change intended, while the last one needs more
> testing and reviewing.
> 
> Andy Shevchenko (8):
>   spi: Introduce internal spi_xfer_is_dma_mapped() helper
>   spi: dw: Use new spi_xfer_is_dma_mapped() helper
>   spi: ingenic: Use new spi_xfer_is_dma_mapped() helper
>   spi: omap2-mcspi: Use new spi_xfer_is_dma_mapped() helper
>   spi: pxa2xx: Use new spi_xfer_is_dma_mapped() helper
>   spi: pci1xxxx: Use new spi_xfer_is_dma_mapped() helper
>   spi: qup: Use new spi_xfer_is_dma_mapped() helper
>   spi: Rework per message DMA mapped flag to be per transfer

Tested on next-20240603. No issue noticed on sc7180-trogdor-kingoftown and
sc7180-trogdor-lazor-limozeen. So,

Tested-by: Nícolas F. R. A. Prado <nfraprado@...labora.com>

Although patch 5 (pxa2xx) didn't apply, so I skipped it (but it's not used on
my platforms).

Thanks,
Nícolas