linux-kernel - Re: [PATCH v1 1/8] spi: Introduce internal spi_xfer_is_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <036ed2c7-02da-4461-940f-591fa68c36fe@linaro.org>
Date: Mon, 3 Jun 2024 23:53:20 +0100
From: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Mark Brown <broonie@...nel.org>, Yang Yingliang <yangyingliang@...wei.com>,
 Christophe JAILLET <christophe.jaillet@...adoo.fr>,
 Thangaraj Samynathan <thangaraj.s@...rochip.com>, linux-spi@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-arm-msm@...r.kernel.org
Cc: Serge Semin <fancer.lancer@...il.com>, Daniel Mack <daniel@...que.org>,
 Haojian Zhuang <haojian.zhuang@...il.com>,
 Robert Jarzmik <robert.jarzmik@...e.fr>,
 Nícolas F . R . A . Prado <nfraprado@...labora.com>,
 Neil Armstrong <neil.armstrong@...aro.org>
Subject: Re: [PATCH v1 1/8] spi: Introduce internal spi_xfer_is_dma_mapped()
 helper

On 31/05/2024 20:42, Andy Shevchenko wrote:
> There are few drivers that use the same pattern to check if the transfer
> is DMA mapped or not. Provide a helper.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>   drivers/spi/internals.h | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/spi/internals.h b/drivers/spi/internals.h
> index 4a28a8395552..47a87c2a6979 100644
> --- a/drivers/spi/internals.h
> +++ b/drivers/spi/internals.h
> @@ -40,4 +40,12 @@ static inline void spi_unmap_buf(struct spi_controller *ctlr,
>   }
>   #endif /* CONFIG_HAS_DMA */
>   
> +static inline bool spi_xfer_is_dma_mapped(struct spi_controller *ctlr,
> +					  struct spi_device *spi,
> +					  struct spi_transfer *xfer)
> +{
> +	return ctlr->can_dma && ctlr->can_dma(ctlr, spi, xfer) &&
> +	       ctlr->cur_msg_mapped;
> +}
> +
>   #endif /* __LINUX_SPI_INTERNALS_H */

Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>